Karmen / Bugs / #2 modifiers disables click to focus

#2 modifiers disables click to focus

Status: closed-fixed

Owner: J. Veenhuizen

Labels: None

Priority: 5

Updated: 2006-09-16

Created: 2006-09-16

Creator: Alejandro Liu

Private: No

Normally clicking anywhere on a window when they do not
have focus brings the window to the front and give it
focus.

When Capslock and/or Numlock are on, this behaviour
does no longer work. You have to click on the window
title bar to active windows.

Discussion

J. Veenhuizen - 2006-09-16

Logged In: YES
user_id=1175650

I will look into it. Thanks!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

J. Veenhuizen - 2006-09-16

assigned_to: nobody --> veenhuizen

status: open --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alejandro Liu - 2006-09-16

Logged In: YES
user_id=516981

Made a patch on fixing this. Wasn't as complicated as I
though...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alejandro Liu - 2006-09-16

diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

J. Veenhuizen - 2006-09-16

Logged In: YES
user_id=1175650

I have a working patch as well. I wrote wrappers around
XGrabKey, XUngrabKey, XGrabButton, XUngrabButton that also
grab/ungrab all combinations of CapsLock and NumLock.

If you came up with a better solution, please send me your
patch.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

J. Veenhuizen - 2006-09-16

Logged In: YES
user_id=1175650

Sorry, I didn't see your attachment.

I think I will use my patch, since it also takes care of key
grabs and doesn't grab more modifiers than necessary.

Thanks again for reporting this bug. I will include the fix
in the next release.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alejandro Liu - 2006-09-16

Logged In: YES
user_id=516981

Thanks,

I think this Window Manager is quite nice. (Simple and
functional). So it is now my WM of choice.

BTW, don't forget to Grab Mod5Mask (Scroll lock), it may not
be very commonly used but would make things complete.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

J. Veenhuizen - 2006-09-16

Logged In: YES
user_id=1175650

The bug has been fixed and committed to SVN.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

J. Veenhuizen - 2006-09-16

status: open-accepted --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

J. Veenhuizen - 2006-09-16

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

J. Veenhuizen - 2006-09-16

Logged In: YES
user_id=1175650

I upload my diff for reference.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

J. Veenhuizen - 2006-09-16

Fix committed to svn

grab.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.