Re: [Kaffeine-devel] Patch attached: Improved seeking with arrow keys (10s, 1min, 10min)

[Zack C. <zc...@co...>]

On Sat March 26 2005 13:58, Christopher Martin wrote:
> >>>>> The attached patch applies to current CVS. It replaces the left/right
> >>>>> arrow seeking +/- 2% with +/- 10 seconds. The up/down arrows seek
> >>>>> +/- 1 minute, and PageUp/PageDown seeks +/- 10 minutes.
> >>>>
> >>>> Well done.
> >>>> It"s in cvs now.
> >>>> PageUp/PageDown is already taken by DVB so i"ve changed to
> >>>> CTRL+PageUp/CTRL+PageDown.
> >>>
> >>> Thanks for committing! Ctrl+PageUp/Down seems pretty obscure, though.
> >>> In an earlier revision of the patch, I used Shift+Left/Right Arrows
> >>> for a larger seek, and I think that might a more intuitive and easy
> >>> to remember key combo than Ctrl-PageUp/Down
> >>
> >> Nice patch! But we should really look for better default shortcuts. I
> >> would prefer only one key + modifiers. Maybe
> >> shift/ctrl+left/right-arrow.
> >
> > By using Up&Down keys you can no longer easily use the keyboard to
> > select an item from the playlist.
> >
> > Maybe consider:
> > Left&Right for 10s.
> > Shift Left&Right for 1m.
> > Alt Left&Right for 10m.
> >
> > and assign (Ctrl + Pg-up) & (Ctrl + Pg-down) or (Shift + Up) & (Shift +
> > Down) for the slow-motion & fast-forward options.
>
> I agree with many of the above comments. Left/Right for 10s,
> Shift+Left/Right for 1 min, and Alt_Left/Right for 10 min seems intuitive
> and easy.

How about instead of using Shift and Alt, using Control and Alt?

Left/Right for 10s
Control+Left/Right for 1m
Alt+Left/Right for 10m

The transition from Control to Alt seems more natural than from Shift to Alt.

> As for the rest of the shortcuts, how about < and > for Slow Motion and
> Fast Forward? The Up/Down arrows could be used for Prev/Next Chapter or
> Entry*. Home and End could be used for Prev/Next in Playlist/Queue, instead
> of the current Alt+Up/Down arrow, though people may be used to that.

I like < and > for Slow/Fast Motion.
What about using Page Up/Down for both skipping tracks and skipping chapters 
(once the below is done)? If you hit Down instead of Right, that'd be a big 
shame in your case. If we need to bind Up/Down to something, maybe they 
should be Slow/Fast Motion?

> * Incidentally, while looking at the code, I noticed that this action,
> which is currently useful mainly for switching chapters in DVDs, had code
> to allow it fall back to switching the playlist entry, if there were no
> chapters to switch. Since that suits the needs of most users most of the
> time, this seems sensible, since then users don't need two sets of
> next/prev shortcuts, and two sets of next/prev buttons in their toolbars.
> This functionality doesn't seem to work at the moment, though, and I was
> wondering if anyone was planning to restore it... ?

I have to rewrite my "Save Position" patch for 0.6, but if nobody's done it by 
then I'll look at it. That won't be for a while, though - hopefully someone 
has more time than I do.

Zack