Menu
▾
▴
[Jython-bugs] [ jython-Patches-1758904 ] I added doc strings for functions in os module (javaos.py).
|
From: SourceForge.net <no...@so...> - 2007-09-24 00:27:33
|
Patches item #1758904, was opened at 2007-07-23 15:43 Message generated for change (Settings changed) made by pjenvey You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312867&aid=1758904&group_id=12867 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Marek Szczypinski (markacy) >Assigned to: Philip Jenvey (pjenvey) Summary: I added doc strings for functions in os module (javaos.py). Initial Comment: I added doc strings for functions in os module (file javaos.py). Didn't change anything else. ---------------------------------------------------------------------- Comment By: Marek Szczypinski (markacy) Date: 2007-09-04 20:53 Message: Logged In: YES user_id=1851562 Originator: YES File Added: javaos.patch ---------------------------------------------------------------------- Comment By: Pekka Laukkanen (laukpe) Date: 2007-07-29 22:51 Message: Logged In: YES user_id=1379331 Originator: NO I submitted a bug [1] about missing utime(path, None) and included a simple patch to fix it. [1] http://jython.org/bugs/1763263 ---------------------------------------------------------------------- Comment By: Pekka Laukkanen (laukpe) Date: 2007-07-27 01:04 Message: Logged In: YES user_id=1379331 Originator: NO I looked at the patch briefly and in general docstrings look good to me especially compared to current ones. Some things that could still be fixed are listed below. - Added docstrings aren't always following PEP 257 Docstring Conventions available at http://www.python.org/dev/peps/pep-0257/ - Docstrings on Python 2.5 os.py have more content than these so perhaps they could be used as a base (keeping in mind that there can be differences between versions). - Mentioning java2 is not really needed in utime since, AFAIK, it means Java 1.2 and Java 1.4 is the minimum for Jython 2.2. The check 'hasattr(File, "setLastModified")' should probably also be removed from the code. - The doc for utime could be slightly more clear since now it first says that atime and mtime are changed and then that only mtime is. Mentioning that the latter is due to Java limitations might be good. - It would be helpful to tell what information is actually returned by stat. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312867&aid=1758904&group_id=12867 |