From: Anders O. <and...@gm...> - 2009-05-12 04:54:53
|
Will try and see what I can do. Has to read up some on generics though. Not that familiar with java generics only used C++ templates but not that much either.. 2009/5/12 Jim Baker <jb...@zy...> > Similar caveats and opportunities apply to what is returned by findbugs. I > did a couple passes through the obvious, easy-to-fix ones yesterday, and of > course I completely ignored generated Antlr code as well as tests. > > Given the scope of changes, I'd recommend the following: > > 1. Follow our coding conventions, especially around the use of Python > unittest if adding tests > 2. Verify your changes by running ant regrtest, ideally on as many > platforms as you have ready access too > 3. Make certain you prepare a patch using svn diff (or equivalent) > 4. Upload to rietveld so we can review, see Frank's blog post on this: > http://fwierzbicki.blogspot.com/2008/08/code-review-with-rietveld.html > 5. Repeat as necessary > > Anyone else who is interested can do the same thing, and it's not limited > to just fixing warnings. We welcome patches for performance, documentation, > better testing, etc. The key is to follow the same sort of practice we do in > development because any type of rewriting on our part creates a big > bottleneck. Also, if you are going to implement a new feature (or two), it > would make sense to get in touch with us on #jython or post your ideas on > jython-dev. > > Working on a codebase like Jython is a great way to grow as a developer, > and there are many entry points. Good luck! > > On Mon, May 11, 2009 at 2:26 PM, Philip Jenvey <pj...@un...>wrote: > >> >> On May 10, 2009, at 11:33 PM, Anders Olme wrote: >> >> > Sound like a fun project :) . When do we start? I'm kind of a java >> > noob but not new to programming so maybe I can offer some help and >> > try to learn something about jython too. >> > >> > 2009/5/11 Philip Jenvey <pj...@un...> >> > Hudson's now tracking compiler warnings (minus Xlint:serial): >> > >> > http://bob.underboss.org:8080/job/jython/805/ >> >> Start now =] >> >> Most of them are "unchecked" type warnings. So first familiarize >> yourself with the basics of Java 1.5's generics if you haven't already >> (which are good to know anyway) and then start picking off some of the >> easier warnings. Many of them just need you to figure out what types >> are being put into a particular container, then add parameterized type >> information in places that need it. It probably won't be too bad of a >> generics learning experience. Feel free to ask us questions on this >> mailing list or on IRC (#jython irc.freenode.net) >> >> You'll want a nice IDE that ideally detects the same warnings Hudson >> does. NetBeans/Eclipse should do it -- though you may need tweak its >> settings to get all of these warnings. >> >> E.g. this commit has a couple unchecked fixes, plus some redundant >> casts: >> >> http://fisheye3.atlassian.com/changelog/jython/?cs=6334 >> >> Note that org.python.antlr.ast is auto generated code (from the ast/ >> asdl_antlr.py script), so don't try fixing their .java files directly. >> I'd also say the javatests/ aren't as high priority as the others >> (plus the warnings I saw in there aren't very straightforward fixes). >> >> -- >> Philip Jenvey >> >> >> >> ------------------------------------------------------------------------------ >> The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your >> production scanning environment may not be a perfect world - but thanks to >> Kodak, there's a perfect scanner to get the job done! With the NEW KODAK >> i700 >> Series Scanner you'll get full speed at 300 dpi even with all image >> processing features enabled. http://p.sf.net/sfu/kodak-com >> _______________________________________________ >> Jython-dev mailing list >> Jyt...@li... >> https://lists.sourceforge.net/lists/listinfo/jython-dev >> > > > > -- > Jim Baker > jb...@zy... > |