Re: [Jython-dev] adding _expectations to regrtest.py

[Oti <oh...@gm...>]

Charlie,

adding _expectations is a very good idea.
My level of detail so far also was only numbers. This is a bit
dangerous as long as we live with quite a few failing or skipped
tests. So we need a way to secure the ones we already made pass.

1.
No, sorry.

2.
The disadvantage of "java.version" System property is that one has to
import System from java.lang. This makes it more difficult (or
verbose) to write code for both CPython and Jython. I don't know how
many people outside regrtests already use the sys.platform[:4]
pattern. Personally I can live with both ways.

best wishes,
Oti.

On 10/17/06, Charlie Groves <cha...@gm...> wrote:
> I broke test_datetime last night with my changes to scope handling.  I
> ran all the tests, but I didn't notice because I just checked that the
> number OK, Failed and Skipped matched what I got beforehand.  It seems
> like adding an entry to _expectations in regrtest.py for Jython would
> make it harder to make that sort of mistake.  I can add the entry but
> I have a couple questions:
>
> 1. Does anyone have a good idea of which tests in the skipped group
> shouldn't be in there?  I can go through them and check by hand, but
> it seems like that must've been known at some point.
>
> 2.  Is there any reason not to change sys.platform to 'java' from
> 'java<version>'?  That'd make the changes to regrtest simpler and I
> think it's closer to the intended meaning of sys.platform.  Each
> version of Jython can run on multiple versions of the JVM but they
> should have identical behavior so I'd say they have the same platform.
>  The important difference with all other platforms is that the JVM is
> under everything.  The test I've seen to detect jython,
> sys.platform[:4] == 'java', seems pretty convoluted for what it's
> doing.  Happily that code still works if we make sys.platform 'java'.
> If someone is trying to see what version of Java is currently in use,
> they could just use the 'java.version' system property.
>
> Thanks,
> Charlie
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Jython-dev mailing list
> Jyt...@li...
> https://lists.sourceforge.net/lists/listinfo/jython-dev
>