From: Pekka Laukkanen <peke@ik...> - 2007-02-17 01:10:45
I started to investigate os.path.abspath bug  I found and was able
to get it fixed. At the same time I fixed related problems in realpath
and samefile, figured out a quite ok solution for bug in normcase 
and did some refactoring/cleanup for javapath.py where all these
methods are implemented.
Before submitting a patch I'd like to create unit tests for all the
changes I made but I couldn't find any tests for javapath.py (it's
quite late at the moment so I might be missing them...). Can someone
point me into right direction? If there aren't any tests ready then
I'll write tests at least for those methods I touched but probably to
others also. Are there some good tests that I could study as an
example in that case?
I've checked out /svnroot/jython/trunk/jython. If and when I'm ready
to create a patch, is it ok just to say "svn diff > javapath.patch" in
From: Charlie Groves <charlie.groves@gm...> - 2007-02-18 07:37:57
On 2/16/07, Pekka Laukkanen <peke@...> wrote:
> Before submitting a patch I'd like to create unit tests for all the
> changes I made but I couldn't find any tests for javapath.py (it's
> quite late at the moment so I might be missing them...). Can someone
> point me into right direction?
As far as I can tell there aren't any tests for javapath or python's
path module either. Of course, it's late here now and I've been
flying all day so I may be even more poorly equipped to find them.
>Are there some good tests that I could study as an
> example in that case?
Of the tests in the stdlib, I prefer the unittest based ones just
because it's easier to isolate a single test case and see where things
are failing. It looks like CPythonLib/test/test_glob.py is a decent
example of that. Make sure it works with CPython as well so we can
contribute it back to them when this is all done.
> I've checked out /svnroot/jython/trunk/jython. If and when I'm ready
> to create a patch, is it ok just to say "svn diff > javapath.patch" in
> that directory?
Sure. Just check the diffs to make sure you haven't inadvertently
changed things unrelated to the patch. If you have, just add the
paths to the files you want included in the diff to the svn diff
It's always good to run dist/Lib/regrtest.py before submitting a patch
as well. It'll report if there are any unexpected failures or skips
of all of the stdlib tests. If it seems like something is failing and
it isn't your fault, check the
buildbot(http://jython.achievewith.us/buildbot/) to see if someone
else has broken something.