Michael,

Sounds good about Indra's fix on bytearray.__len__, just need to put in an appropriate test and this looks great. I can readily write that test. (Might also be on a separate email.)

Re stack.patch - this might be just the sort of thing we want to give a Jython user more info because Python recursion limit exceptions are (annoyingly) triggered differently than Java StackOverflowErrors. For those not looking at the patch text:

-            return Py.RuntimeError("maximum recursion depth exceeded");
+            return Py.RuntimeError("maximum recursion depth exceeded (Java StackOverflowError)");

Any thoughts by other devs on why we should not do this? Otherwise I will add it in as well.

- Jim



On Wed, May 14, 2014 at 5:22 PM, Michael Büsch <m@bues.ch> wrote:
On Wed, 14 May 2014 14:09:57 -0700
"fwierzbicki@gmail.com" <fwierzbicki@gmail.com> wrote:

> We are planning to soft launch beta 3 this coming Friday. If there's a
> bug that can be quickly fixed - ideally with a patch (or if someone
> has a reason to delay beta 3) please tell us know!

I'd like to see the bytearray __len__ fix being applied.
This is a showstopper bug for me that is not easily worked around.
Also, the patch seems to be pretty straightforward.

The fix by Indra Talip <indra.talip@gmail.com> is attached
as bytearray_len_fix.patch

My proposal to improve the exception message by making clear that this
is not a Python stack overflow, but a Java stack overflow, is attached
as stack.patch


--
Michael.

----
Please use PGP/GPG encryption.
Key-ID: F532BE1D908D8B0E
--------

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Jython-dev mailing list
Jython-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jython-dev