Good suggestion, but it should be linked to the Java 5 javadocs, since that is our current compatibility level.

I've reviewed the first two of your patches (toArray and indexOf), and improved a bit further on toArray, I'll commit them as soon as I've checked the regression tests.

When it comes yo your main patch (about null for traceback in the exception tuples), I think you have found an excellent cutting point. I was going to look at it and suggest that you do the conversion where the PyTuple is instantiated, but I can see that is what you have done.

Any other opinions? Otherwise I'll check in Andreas fix.

The real solution would of course be to change PyException to not expose its fields and have this conversion done in an accessor method instead. But that is a substantial refactoring, and something we should defer for now.

/Tobias

On Mon, Aug 3, 2009 at 11:39 PM, Andrea <mariofutire@googlemail.com> wrote:
Hi,

I think it would be useful to add the link to Java's javadoc

http://java.sun.com/javase/6/docs/api/

from Jython generated javadoc.

Minor issue could be which version of Java (my choice is of the latest).

It is a matter of adding

<link href="http://java.sun.com/javase/6/docs/api/" />

in the build.xml for ant.

If necessary, the link can be made not to require an Internet connection.

Andrea


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Jython-dev mailing list
Jython-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jython-dev