From: Vladimir B. <vla...@bo...> - 2001-10-25 18:16:19
|
Proposition for adding the getName() method to the Test interface: * in the version 3.8 - create a Test2 that extends Test and adds getName() - mark Test as deprecated - TestSuite and TestCase now implement Test2 - _but_ all clients ui still work with the Test interface ... in the meantime users using 3.8 and having home-made classes that implement the Test interface update their code... * in the version 3.9 - delete the Test.java file - modify all clients to only recognize the Test2 interface It's also possible to add a method to the Test interface directly but some users will have their tests broken. The only requirement is to first use 3.8 before 3.9. -Vladimir -- Vladimir Bossicard www.bossicard.com |
From: Erik M. <em...@ge...> - 2001-10-25 21:14:16
|
If folks don't have too many objections I would like to take a stab at setting up synchmail to send emails about CVS activity to this list. The last few days I have felt kind of odd seeing build results without indication of what was changed. (faq.htm and testing.htm) More info can be found at: http://sourceforge.net/docman/display_doc.php?docid=772&group_id=1 Erik |
From: Erik M. <em...@ge...> - 2001-10-27 21:30:31
|
I've run into a problem with this and submitted a support request. Until this is resolved you may see the following when checking anything into CVS: sh: /cvsroot/junit/CVSROOT/syncmail: Permission denied This has no effect on your commit, it is just syncmail not executing. More information is available in the support request: http://sourceforge.net/tracker/?func=detail&aid=475663&group_id=1&atid=20000 1 I don't want to disable syncmail in an effort to make things as easy as possible for the support team. Erik > -----Original Message----- > From: jun...@li... > [mailto:jun...@li...]On Behalf Of Erik Meade > Sent: Thursday, October 25, 2001 4:16 PM > To: JUnit-Devel > Subject: [Junit-devel] CVS activity emailed to this list > > > If folks don't have too many objections I would like to take a stab at > setting up synchmail to send emails about CVS activity to this list. > > The last few days I have felt kind of odd seeing build results without > indication of what was changed. (faq.htm and testing.htm) > > More info can be found at: > > http://sourceforge.net/docman/display_doc.php?docid=772&group_id=1 > > Erik > > > _______________________________________________ > Junit-devel mailing list > Jun...@li... > https://lists.sourceforge.net/lists/listinfo/junit-devel |
From: Erik M. <em...@ge...> - 2001-10-27 22:15:45
|
Thanks to the quick work of moorman, of the SF support staff, we are in business. Erik > -----Original Message----- > From: jun...@li... > [mailto:jun...@li...]On Behalf Of Erik Meade > Sent: Saturday, October 27, 2001 4:32 PM > To: JUnit-Devel > Subject: RE: [Junit-devel] CVS activity emailed to this list > > > I've run into a problem with this and submitted a support request. Until > this > is resolved you may see the following when checking anything into CVS: > > sh: /cvsroot/junit/CVSROOT/syncmail: Permission denied > > This has no effect on your commit, it is just syncmail not > executing. More > information is available in the support request: > > http://sourceforge.net/tracker/?func=detail&aid=475663&group_id=1& > atid=20000 > 1 > > I don't want to disable syncmail in an effort to make things as easy as > possible > for the support team. > > Erik > > > -----Original Message----- > > From: jun...@li... > > [mailto:jun...@li...]On Behalf Of Erik Meade > > Sent: Thursday, October 25, 2001 4:16 PM > > To: JUnit-Devel > > Subject: [Junit-devel] CVS activity emailed to this list > > > > > > If folks don't have too many objections I would like to take a stab at > > setting up synchmail to send emails about CVS activity to this list. > > > > The last few days I have felt kind of odd seeing build results without > > indication of what was changed. (faq.htm and testing.htm) > > > > More info can be found at: > > > > http://sourceforge.net/docman/display_doc.php?docid=772&group_id=1 > > > > Erik > > > > > > _______________________________________________ > > Junit-devel mailing list > > Jun...@li... > > https://lists.sourceforge.net/lists/listinfo/junit-devel > > > _______________________________________________ > Junit-devel mailing list > Jun...@li... > https://lists.sourceforge.net/lists/listinfo/junit-devel |
From: Erik M. <em...@ge...> - 2001-10-31 19:48:23
|
Uncle Bob and I paired on this patch. At this point the awtui and swingui's TestRunner's rerunTest methods are identical. So where do we put it? Index: awtui/TestRunner.java =================================================================== RCS file: /cvsroot/junit/junit/junit/awtui/TestRunner.java,v retrieving revision 1.7 diff -u -w -r1.7 TestRunner.java --- awtui/TestRunner.java 2001/10/29 19:47:45 1.7 +++ awtui/TestRunner.java 2001/10/31 19:43:33 @@ -333,6 +333,10 @@ return; Test test= (Test)fFailedTests.elementAt(index); + rerunTest(test); + } + + private void rerunTest(Test test) { if (!(test instanceof TestCase)) { showInfo("Could not reload "+ test.toString()); return; Index: swingui/TestRunner.java =================================================================== RCS file: /cvsroot/junit/junit/junit/swingui/TestRunner.java,v retrieving revision 1.9 diff -u -w -r1.9 TestRunner.java --- swingui/TestRunner.java 2001/10/29 19:47:45 1.9 +++ swingui/TestRunner.java 2001/10/31 19:43:33 @@ -553,8 +553,8 @@ try { Class reloadedTestClass= getLoader().reload(test.getClass()); Class[] classArgs= { String.class }; - Object[] args= new Object[]{((TestCase)test).getName()}; Constructor constructor= reloadedTestClass.getConstructor(classArgs); + Object[] args= new Object[]{((TestCase)test).getName()}; reloadedTest=(Test)constructor.newInstance(args); } catch(Exception e) { showInfo("Could not reload "+ test.toString()); |
From: Erik M. <em...@ge...> - 2001-10-25 21:14:16
|
TestDecorator and DoubleTestCase in TestImplementorTest would have to implement it. Are there any objections to just adding getName to Test now? Erik > -----Original Message----- > From: jun...@li... > [mailto:jun...@li...]On Behalf Of Vladimir > Bossicard > Sent: Thursday, October 25, 2001 1:15 PM > To: JUnit-Devel > Subject: [Junit-devel] Test2 interface > > > Proposition for adding the getName() method to the Test interface: > > * in the version 3.8 > - create a Test2 that extends Test and adds getName() > - mark Test as deprecated > - TestSuite and TestCase now implement Test2 > - _but_ all clients ui still work with the Test interface > > ... in the meantime users using 3.8 and having home-made classes that > implement the Test interface update their code... > > * in the version 3.9 > - delete the Test.java file > - modify all clients to only recognize the Test2 interface > > It's also possible to add a method to the Test interface directly but > some users will have their tests broken. > > The only requirement is to first use 3.8 before 3.9. > > -Vladimir > > -- > Vladimir Bossicard > www.bossicard.com > > > _______________________________________________ > Junit-devel mailing list > Jun...@li... > https://lists.sourceforge.net/lists/listinfo/junit-devel |
From: Erich G. <eri...@ac...> - 2001-11-03 10:29:56
|
I have no objections to just add getName now. Some clients like JUnitPerf will be broken for some time but I assume they will catch-up soon given that this is a trivial change. Vladimir's suggestion is good and a way to keep the API stable in the face of interface changes. However, the cost is that we end up with non-obvious core interface name Test2. The tricky part of deprecation is when to remove the deprecated code. If we remove it in 3.9 we will still break clients that don't track JUnit. Clients tracking JUnit will migrate immediatly anyways. Notice, that the JDK practice with regard to deprecate removal is to never remove them. --erich At 04:16 PM 10/25/2001 -0500, Erik Meade wrote: >TestDecorator and DoubleTestCase in TestImplementorTest would have to >implement it. Are >there any objections to just adding getName to Test now? > >Erik > >> -----Original Message----- >> From: jun...@li... >> [mailto:jun...@li...]On Behalf Of Vladimir >> Bossicard >> Sent: Thursday, October 25, 2001 1:15 PM >> To: JUnit-Devel >> Subject: [Junit-devel] Test2 interface >> >> >> Proposition for adding the getName() method to the Test interface: >> >> * in the version 3.8 >> - create a Test2 that extends Test and adds getName() >> - mark Test as deprecated >> - TestSuite and TestCase now implement Test2 >> - _but_ all clients ui still work with the Test interface >> >> ... in the meantime users using 3.8 and having home-made classes that >> implement the Test interface update their code... >> >> * in the version 3.9 >> - delete the Test.java file >> - modify all clients to only recognize the Test2 interface >> >> It's also possible to add a method to the Test interface directly but >> some users will have their tests broken. >> >> The only requirement is to first use 3.8 before 3.9. >> >> -Vladimir >> >> -- >> Vladimir Bossicard >> www.bossicard.com >> >> >> _______________________________________________ >> Junit-devel mailing list >> Jun...@li... >> https://lists.sourceforge.net/lists/listinfo/junit-devel > > >_______________________________________________ >Junit-devel mailing list >Jun...@li... >https://lists.sourceforge.net/lists/listinfo/junit-devel > > > |
From: Kent B. <ken...@cs...> - 2001-10-26 00:09:06
|
Our usual procedures would require such a dance. I'm willing to risk just adding getName() to Test and seeing what happens. Kent |
From: Erik M. <em...@ge...> - 2001-10-29 21:05:17
|
Adding getName to the Test interface and implementing it in those classes which implement Test and don't already have getName(). If this is going to go into the Halloween release we need to move on it... Erik Index: junit/extensions/TestDecorator.java =================================================================== RCS file: /cvsroot/junit/junit/junit/extensions/TestDecorator.java,v retrieving revision 1.4 diff -u -r1.4 TestDecorator.java --- junit/extensions/TestDecorator.java 2001/10/24 04:21:17 1.4 +++ junit/extensions/TestDecorator.java 2001/10/29 20:55:57 @@ -35,4 +35,8 @@ public Test getTest() { return fTest; } + + public String getName() { + return fTest.getName(); + } } Index: junit/framework/Test.java =================================================================== RCS file: /cvsroot/junit/junit/junit/framework/Test.java,v retrieving revision 1.3 diff -u -r1.3 Test.java --- junit/framework/Test.java 2001/10/24 04:21:17 1.3 +++ junit/framework/Test.java 2001/10/29 20:55:57 @@ -14,4 +14,8 @@ * Runs a test and collects its result in a TestResult instance. */ public abstract void run(TestResult result); + /** + * Returns the name of the test. + */ + public abstract String getName(); } Index: junit/tests/TestImplementorTest.java =================================================================== RCS file: /cvsroot/junit/junit/junit/tests/TestImplementorTest.java,v retrieving revision 1.2 diff -u -r1.2 TestImplementorTest.java --- junit/tests/TestImplementorTest.java 2001/10/22 21:12:02 1.2 +++ junit/tests/TestImplementorTest.java 2001/10/29 20:56:01 @@ -29,8 +29,8 @@ result.endTest(this); } - public String getDisplayName() { - return ""; + public String getName() { + return fTestCase.getName(); } } |