Re: [JPP-Devel] A couple of changes for the PlugInManager class.

[Larry B. <bec...@gm...>]

Hi SS,

  OK, I tried your scenario by listing the following in default-plugins.xml:

<plug-in>org.openjump.core.ui.plugin.edittoolbox.cursortools.CutPolygonTool</plug-in>

I got an "Instantiation error" exception and OJ hung up.  I agree that this
is not good behavior.  If you have a fix for it, I think OJ should use it,
and moving toURLS to FileUtil makes sense to me.

regards,
Larry

On Mon, Oct 12, 2009 at 3:00 PM, Sunburned Surveyor <
sun...@gm...> wrote:

> I'd like to suggest a couple of minor changes to the PlugInManager class:
>
> - Check for valid implementations of the PlugIn class in the
> loadPlugInClasses method. This will prevent program load problems if
> someone inadvertently lists a non-plug-in class in the workbench
> properties file. It doesn't appear from my inspection that this check
> is being made currently in the PlugInManager or the
> WorkbenchPropertiesFile (at least not in the original JUMP source
> code).
>
> - Add source code comments immediately before the statements that can
> generate exceptions during class loading and
> initialization/configuration. The PlugInManager class throws
> exceptions in several places, and these are hard to identify without
> the comments.
>
> - Move the toURLS method from PlugInManager to the FileUtil class.
>
> I've already made these and other changes to the PlugInManager class
> in BizzJUMP. I can create patches for Stefan, Larry or others to
> review for just the changes I list above.
>
> The Sunburned Surveyor
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> Jump-pilot-devel mailing list
> Jum...@li...
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>



-- 
Larry Becker
Integrated Systems Analysts, Inc.