Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#7 unifdef.c Needs patch (Patch provided)

closed-fixed
nobody
None
5
2004-06-06
2002-09-10
Seth Delackner
No

The unifdef.c that is provided in the Judy source tree at
tool/unifdef.c

line 580:
if (isprint (chr)) {

Should be:
if (chr != EOF && isprint (chr)) {

Without the char != EOF test, on my system (OpenBSD
3.0) upon hitting EOF, the program continues spewing
junk output because it thinks EOF is a printable character.

Discussion

  • Logged In: YES
    user_id=558029

    It's actually worse that that. I have found that verious
    isprint(chr) on different
    releases of verious flavors of BSD have different kind of
    bugs. Therefore,
    I have modified unifdef.c to not use isprint(). It will be
    in an upcomming
    release of Judy. If you need a copy sooner, email me:
    Doug Baskins
    doug@sourcejudy.com

     
    • status: open --> closed-fixed
     
  • Logged In: YES
    user_id=558029

    Fixed in version 0.1.7 available at
    <http://judy.sourceforge.net/downloads>
    Judy has been modified to not use unifdef. Many bugs were found in the
    librarys in *BSD that were used by unifdef.c.