[Rainer Schwarze]

Hi,

the patch replaces the built-in DES and MD5 implementation with code which uses the crypto modules in the java.security / javax.crypto packages. This addresses export regulations. Test cases were added to make sure, that the code behaves the same as the previous built-in implementation. (Test cases passed with previous implementation and pass with the new implementation.)

Best wishes,
Rainer Schwarze

PS1: A patch snippet for NtlmAuthTest.java has slipped in which just changes the order of imports.This can be excluded without any problem.

PS2: The patch for README.SSO contains also a few hunks which change whitespace only - the first hunk is a real change. If whitespace shall not be changed, those hunks can be excluded as well.

Patch for using JDK crypto instead of built-in

Hi Rainer,

I had a look at your changes and think it would be quite feasible to replace the current code, just as you suggested. The only thing is, that it seems that we would have to drop Java 1.3 support to make use of the build-in crypto features. But since I wouldn't expect to still find too many Java 1.3 systems in the wild, maybe finally its just time to take the step forward to a more recent Java version. I think I'll simply open a new 1.3 branch (to be able to apply critical bug fixes to the current code base) and then apply your patch to that next version. I'm still unsure whether to go up to Java 7 or stick to Java 6, but taking into account that Java 6 has already been released in 2006 I'd even prefer Java 7... Anyway, thanks for still supporting the jTDS project and keep up the good work!

Cheers,
momo

• milestone: --> v1.3

• status: open --> accepted

• status: accepted --> closed

Hi Rainer,

I applied the patch to the jTDS 1.3 branch in SVN revision [1135]. Thanks again for contributing!

Cheers,
momo