#39 let 'make-parser' see '-' as alphanumeric

open
nobody
None
5
2005-02-21
2005-02-21
Jelte Jansen
No

The error/warning parser of the command execution
already sees the underscore as an alphanumeric
character, because a lot of filenames contain it. In my
projects, there are also a lot of files that contain a
dash. So i have added them to the list of
"alphanumerical" characters. Don't know if it's useful
but i thought i'd just submit it.

Also, the last part of the diff causes the parser to
only parse the filenames that are at the beginning of a
line (i got a lot of false positives in lines
containing ':' here).

Jelte

Discussion

  • Joe Allen
    Joe Allen
    2005-02-26

    Logged In: YES
    user_id=1000448

    I didn't want to globally add '-' to identifier characters,
    so I've modified uerror.c so that '-' is allowed in names,
    but only there.

    False positives are a big problem. I should really have a
    user defined regex for matching compiler errors.

     
  • Joe Allen
    Joe Allen
    2005-02-26

    Logged In: YES
    user_id=1000448

    I didn't want to globally add '-' to identifier characters,
    so I've modified uerror.c so that '-' is allowed in names,
    but only there.

    False positives are a big problem. I should really have a
    user defined regex for matching compiler errors.

     
  • Jelte Jansen
    Jelte Jansen
    2005-02-28

    Logged In: YES
    user_id=1148720

    yeah i understand and i agree with the problem of false
    positives, i didn't think the patch would make it but i
    submitted it so other people can use it too if they want. A
    full-fledged RE is probably the best solution indeed. A
    temporary one could be to have an optional list of matching
    characters in .joerc.

    Is something like this worth making a (optional) dependency
    on something like regex.h?