From: Shiller, P. J. <pau...@ti...> - 2007-09-26 20:16:08
|
The following fix was sent to me and I am posting it to the list server for= others to see=2E=0D=0A=0D=0AAlong with the fix below I also tried: =0D=0A= =0D=0AReplace: $this->mJmolTagPresent =3D false; in function onParserBef= oreStrip=0D=0AWith: return $this->mJmolTagPresent =3D false;=0D=0A= =0D=0AAnd =0D=0A=0D=0AReplace: $this->mJmolTagPresent =3D false; in functi= on onParserAfterStrip=0D=0AWith: return $this->mJmolTagPresent =3D fal= se;=0D=0A=0D=0AThese replacements work on my system=2E=0D=0A=0D=0APaul Shil= ler=0D=0ATribological Specialist=0D=0APh:+1-330-471-3344=0D=0AEMail: Paul= =2EShiller@timken=2Ecom=0D=0A-----Original Message-----=0D=0AFrom: Nicolas = Vervelle [mailto:nvervelle@numericable=2Efr] =0D=0ASent: Wednesday, Septemb= er 26, 2007 3:18 PM=0D=0ATo: jmol-users@lists=2Esourceforge=2Enet=0D=0ACc: = Shiller, Paul J=2E=0D=0ASubject: Re: [Jmol-users] Internal error - embeddin= g Jmol in MediaWiki=0D=0A=0D=0AHi,=0D=0A=0D=0AMy mail probably won't reach = the mailing list (problems with my ISP), =0D=0Acan you forward it to the jm= ol-users mailing list so that other users =0D=0Acan participate ?=0D=0A=0D= =0AI haven't worked for a long time on the extension mostly due to a lack = =0D=0Aof time=2E I know people are interested in getting it on Wikipedia (s= orry =0D=0Afor having not worked on it recently), so if someone is interest= ed in =0D=0Acontinuing development (especially the security part), he would= be very =0D=0Awelcome :)=0D=0A=0D=0AConcerning your problem, it seems that= recent versions of Mediawiki are =0D=0Amore strict on the hooks=2E=0D=0AI = think the fix is quite simple=2E Can you try it ?=0D=0ASimply add "return t= rue;" at the end of both onParserBeforeStrip and =0D=0AonParserAfterStrip ?= =0D=0AMediawiki should be happy with this fix=2E=0D=0A=0D=0AKeep us posted = with the results=2E=0D=0A=0D=0ANico=0D=0A=0D=0A=0D=0AShiller, Paul J=2E a = =E9crit :=0D=0A> I have been trying to get Jmol to work on a MediaWiki proj= ect I am=0D=0A> starting=2E I have followed the installation instructions = including=0D=0A> creating the JmolExtension=2Ephp file=2E On the first att= empt the Wiki was=0D=0A> "Unable to display the [main] Page"=2E Removing t= he "require_once"=0D=0A> instruction in the LocalSettings=2Ephp file allowe= d me to start the Wiki=2E=0D=0A> Starting the Wiki and changing the LocalSe= ttings (activating the=0D=0A> "require_once" instruction)led to the followi= ng debug information:=0D=0A>=0D=0A> Internal error=0D=0A>=0D=0A> Detected b= ug in an extension! Hook JmolExtension::onParserBeforeStrip=0D=0A> failed t= o return a value; should return true to continue hook processing=0D=0A> or = false to abort=2E=0D=0A>=0D=0A> Backtrace:=0D=0A>=0D=0A> #0 E:\PortableApps= \xampp\htdocs\wi\includes\Parser=2Ephp(303):=0D=0A> wfRunHooks()=0D=0A> #1 = E:\PortableApps\xampp\htdocs\wi\includes\Article=2Ephp(3017):=0D=0A> Parser= ->parse('ParserBeforeStr=2E=2E=2E', Array)=0D=0A> #2 E:\PortableApps\xampp\= htdocs\wi\includes\Article=2Ephp(831):=0D=0A> Article->outputWikiText('<big= >'''Welcome=2E=2E=2E', Object(Title),=0D=0A> Object(ParserOptions), true, t= rue, 87)=0D=0A> #3 E:\PortableApps\xampp\htdocs\wi\includes\Wiki=2Ephp(383)= :=0D=0A> Article->view('<big>'''Welcome=2E=2E=2E')=0D=0A> #4 E:\PortableApp= s\xampp\htdocs\wi\includes\Wiki=2Ephp(48):=0D=0A> MediaWiki->performAction(= )=0D=0A> #5 E:\PortableApps\xampp\htdocs\wi\index=2Ephp(89):=0D=0A> MediaWi= ki->initialize(Object(OutputPage), Object(Article),=0D=0A> Object(Title), O= bject(User), Object(WebRequest))=0D=0A> #6 {main}=0D=0A>=0D=0A> Are there a= ny suggestions on how to fix this? As you can tell from the=0D=0A> above t= est I am running this under the Portable Apps, xampp installation=0D=0A> on= a Windows XP system=2E=0D=0A>=0D=0A> Paul Shiller=0D=0A> =0D=0A=0D=0A=0D= =0A-----------------------------------------=0D=0AThis message and any atta= chments are intended for the individual or=0Aentity named above=2E If you a= re not the intended recipient, please=0Ado not forward, copy, print, use or= disclose this communication to=0Aothers; also please notify the sender by = replying to this message,=0Aand then delete it from your system=2E The Timk= en Company / The=0ATimken Corporation |
From: pim s. <pim...@go...> - 2007-09-28 18:29:34
|
Oh, and could you (or someone else) update this fixes to the wiki.jmol.org page as well? Since you are apparently the last person who followed the instructions of that page you probably know best how to put it :) On 9/26/07, Shiller, Paul J. <pau...@ti...> wrote: > The following fix was sent to me and I am posting it to the list server for others to see. > > Along with the fix below I also tried: > > Replace: $this->mJmolTagPresent = false; in function onParserBeforeStrip > With: return $this->mJmolTagPresent = false; > > And > > Replace: $this->mJmolTagPresent = false; in function onParserAfterStrip > With: return $this->mJmolTagPresent = false; > > These replacements work on my system. > > Paul Shiller > Tribological Specialist > Ph:+1-330-471-3344 > EMail: Pau...@ti... > -----Original Message----- > From: Nicolas Vervelle [mailto:nve...@nu...] > Sent: Wednesday, September 26, 2007 3:18 PM > To: jmo...@li... > Cc: Shiller, Paul J. > Subject: Re: [Jmol-users] Internal error - embedding Jmol in MediaWiki > > Hi, > > My mail probably won't reach the mailing list (problems with my ISP), > can you forward it to the jmol-users mailing list so that other users > can participate ? > > I haven't worked for a long time on the extension mostly due to a lack > of time. I know people are interested in getting it on Wikipedia (sorry > for having not worked on it recently), so if someone is interested in > continuing development (especially the security part), he would be very > welcome :) > > Concerning your problem, it seems that recent versions of Mediawiki are > more strict on the hooks. > I think the fix is quite simple. Can you try it ? > Simply add "return true;" at the end of both onParserBeforeStrip and > onParserAfterStrip ? > Mediawiki should be happy with this fix. > > Keep us posted with the results. > > Nico -- Greetings, Pim http://www.molmod.com |