#268 Error Propagation Bugs

bug
open
kernel (207)
5
2008-11-10
2008-10-27
No

Hi,

We have statically analyzed Linux 2.6.27 to find error propagation bugs in file system implementations. Here is the file and line numbers at which we find that errors are dropped. The attached file includes traces that further explained each of these bugs.

fs/jfs/inode.c:150: potential non-tentative unchecked error is not saved
fs/jfs/inode.c:337: potential non-tentative unchecked error is not saved
fs/jfs/inode.c:363: potential non-tentative unchecked error is not saved
fs/jfs/inode.c:373: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dmap.c:1976: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dmap.c:2039: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dmap.c:246: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dmap.c:2493: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dmap.c:2503: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dmap.c:305: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dmap.c:3259: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dtree.c:1051: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dtree.c:1056: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dtree.c:1304: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dtree.c:2857: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dtree.c:2963: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dtree.c:410: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dtree.c:419: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dtree.c:461: potential non-tentative unchecked error is not saved
fs/jfs/jfs_dtree.c:999: potential non-tentative unchecked error is not saved
fs/jfs/jfs_extent.c:145: potential non-tentative unchecked error is not saved
fs/jfs/jfs_extent.c:166: potential non-tentative unchecked error is not saved
fs/jfs/jfs_extent.c:187: potential non-tentative unchecked error is not saved
fs/jfs/jfs_imap.c:1682: potential non-tentative unchecked error is not saved
fs/jfs/jfs_imap.c:205: potential non-tentative unchecked error is not saved
fs/jfs/jfs_imap.c:2550: potential non-tentative unchecked error is not saved
fs/jfs/jfs_imap.c:2569: potential non-tentative unchecked error is not saved
fs/jfs/jfs_imap.c:268: potential non-tentative unchecked error is not saved
fs/jfs/jfs_imap.c:3025: potential non-tentative unchecked error is not saved
fs/jfs/jfs_imap.c:3042: potential non-tentative unchecked error is not saved
fs/jfs/jfs_imap.c:567: potential non-tentative unchecked error is not saved
fs/jfs/jfs_logmgr.c:1482: potential non-tentative unchecked error is not saved
fs/jfs/jfs_logmgr.c:1494: potential non-tentative unchecked error is not saved
fs/jfs/jfs_logmgr.c:1690: potential non-tentative unchecked error is not saved
fs/jfs/jfs_metapage.c:710: potential non-tentative unchecked error is not saved
fs/jfs/jfs_metapage.c:755: potential non-tentative unchecked error is not saved
fs/jfs/jfs_mount.c:279: potential non-tentative unchecked error is not saved
fs/jfs/jfs_mount.c:452: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:1315: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2416: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2464: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2475: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2484: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2526: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2537: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2548: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2566: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2575: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2585: potential non-tentative unchecked error is not saved
fs/jfs/jfs_txnmgr.c:2886: potential non-tentative unchecked error is not saved
fs/jfs/jfs_umount.c:111: potential non-tentative unchecked error is not saved
fs/jfs/jfs_umount.c:154: potential non-tentative unchecked error is not saved
fs/jfs/jfs_umount.c:155: potential non-tentative unchecked error is not saved
fs/jfs/jfs_umount.c:163: potential non-tentative unchecked error is not saved
fs/jfs/jfs_umount.c:165: potential non-tentative unchecked error is not saved
fs/jfs/jfs_xtree.c:2533: potential non-tentative unchecked error is not saved
fs/jfs/jfs_xtree.c:880: potential non-tentative unchecked error is not saved
fs/jfs/namei.c:1016: potential non-tentative unchecked error is not saved
fs/jfs/namei.c:55: potential non-tentative unchecked error is not saved
fs/jfs/namei.c:757: potential non-tentative unchecked error is not saved
fs/jfs/namei.c:993: potential non-tentative unchecked error is not saved
fs/jfs/resize.c:219: potential non-tentative unchecked error is not saved
fs/jfs/resize.c:250: potential non-tentative unchecked error is not saved
fs/jfs/resize.c:366: potential non-tentative unchecked error is not saved
fs/jfs/resize.c:378: potential non-tentative unchecked error is not saved
fs/jfs/resize.c:379: potential non-tentative unchecked error is not saved
fs/jfs/resize.c:523: potential non-tentative unchecked error is not saved
fs/jfs/super.c:534: potential non-tentative unchecked error is not saved
fs/jfs/super.c:553: potential non-tentative unchecked error is not saved
fs/jfs/super.c:554: potential non-tentative unchecked error is not saved
fs/jfs/super.c:565: potential non-tentative unchecked error is not saved
fs/jfs/super.c:878: potential non-tentative unchecked error is not saved
fs/jfs/xattr.c:337: potential non-tentative unchecked error is not saved
fs/jfs/xattr.c:562: potential non-tentative unchecked error is not saved
fs/jfs/xattr.c:573: potential non-tentative unchecked error is not saved
fs/jfs/xattr.c:619: potential non-tentative unchecked error is not saved
fs/jfs/jfs_extent.c:575: potential non-tentative unchecked error in out of scope variable "rc"
fs/jfs/jfs_imap.c:1289: potential non-tentative unchecked error in out of scope variable "rc"
fs/jfs/jfs_imap.c:2913: potential non-tentative unchecked error in out of scope variable "rcx"
fs/jfs/jfs_imap.c:2991: potential non-tentative unchecked error in out of scope variable "rcx"
fs/jfs/jfs_txnmgr.c:3009: potential non-tentative unchecked error in out of scope variable "rc"
fs/jfs/namei.c:1330: potential non-tentative unchecked error in out of scope variable "new_size"
fs/jfs/namei.c:594: potential non-tentative unchecked error in out of scope variable "new_size"
fs/jfs/super.c:725: potential non-tentative unchecked error in out of scope variable "err"
fs/jfs/xattr.c:1084: potential non-tentative unchecked error in out of scope variable "xattr_size"
fs/jfs/namei.c:1122: overwriting potential non-tentative unchecked error in "rc"
fs/jfs/namei.c:1127: overwriting potential non-tentative unchecked error in "rc"
fs/jfs/namei.c:1303: overwriting potential non-tentative unchecked error in "rc"
fs/jfs/namei.c:567: overwriting potential non-tentative unchecked error in "rc"

Discussion

  • Complete traces

     
    Attachments
  • David Kleikamp
    David Kleikamp
    2008-11-07

    • assigned_to: nobody --> shaggyk
     
  • David Kleikamp
    David Kleikamp
    2008-11-10

    I've taken a look at the bugs and categorized them with a brief statement about how they should be corrected, or why they will not be.

    Toward the end of this list are several bug reports which appear to be mistaken.

    If I was too brief on any of these, I'd be happy to elaborate on them.

    I can't promise how soon I'll fix these, but I'll try to get started this week.
    File Added: short.categorized

     
  • David Kleikamp
    David Kleikamp
    2008-11-10

    • labels: --> kernel
    • milestone: --> bug
     
  • David Kleikamp
    David Kleikamp
    2008-11-10

    bugs broken down by corrective action to be taken

     
    Attachments
  • Thank you very much for taking the time to go through all the reports. Your detailed categorization is invaluable and helps us to assess the results. I also wanted to thank you for commenting on the reports that cannot be fixed either because there is nothing that can be done about it or because the report is simply a false positive. This definitely helps us to improve our tool.

    Please don't hesitate to contact us if you are interested in having the error propagation analysis performed in any future release.

    Thanks again!

     
  • The following wow gold http://www.mmogm.com/wow/ is great! bring in all of these books enough time. My very own other relatives and will be addicts pertaining to all these!! We each have at minimum Three or more twos! This straight down autumn pertaining to these are typically whenever you bring in these people declare small jeans the jeans will quickly emerge from typically the wow gold http://www.mmogm.com/wow/, as is also concise, credit rating not necessarily small more than enough(the jeans). Besides that...Really enjoy These individuals!!!!!!