[Jfreereport-commits] [Pentaho Reporting SVN] - r14198 - PRD-3540: Make sure that the text parameter always has valid inputs after the edit. With these extra checks I can be sure that no value is taken from an hidden component.

[<pen...@pe...>]

Author: tmorgner
Date: 2011-07-28 10:48:21 -0400 (Thu, 28 Jul 2011)
New Revision: 14198

Modified:
   tools/report-designer/branches/3.8/report-designer/src/org/pentaho/reporting/designer/core/editor/parameters/ParameterDialog.java
Log:
PRD-3540: Make sure that the text parameter always has valid inputs after the edit. With these extra checks I can be sure that no value is taken from an hidden component.

Modified: tools/report-designer/branches/3.8/report-designer/src/org/pentaho/reporting/designer/core/editor/parameters/ParameterDialog.java
===================================================================
--- tools/report-designer/branches/3.8/report-designer/src/org/pentaho/reporting/designer/core/editor/parameters/ParameterDialog.java	2011-07-28 14:47:28 UTC (rev 14197)
+++ tools/report-designer/branches/3.8/report-designer/src/org/pentaho/reporting/designer/core/editor/parameters/ParameterDialog.java	2011-07-28 14:48:21 UTC (rev 14198)
@@ -1474,7 +1474,7 @@
       parameter.setParameterAttribute
           (ParameterAttributeNames.Core.NAMESPACE, ParameterAttributeNames.Core.DATA_FORMAT, dataFormat);
     }
-    if (queryIsOptional)
+    if (queryIsOptional == false)
     {
       parameter.setParameterAttribute
           (ParameterAttributeNames.Core.NAMESPACE, ParameterAttributeNames.Core.DISPLAY_VALUE_FORMULA,