#263 SWT: patch for properties dialog when parent is modal

open
nobody
None
5
2012-11-27
2010-02-09
hoelle29A
No

This patch changes the way the shell for the chart properties dialog is created.

In my application I displayed a chart in a modal swt dialog. The user was able to open the chart properties window but unable to use it as the parent dialog stayed in the foreground. The reason is that currently in SWTChartEditor the shell is derived from the parents dialog display. When deriving from the parents dialog shell everything works as expected.

Extract from the org.eclipse.jface.dialogs.Dialog javadoc:
"If there is more than one modal dialog is open the second one should be parented off of the shell of the first one otherwise it is possible that the OS will give focus to the first dialog potentially blocking the UI."

Additionally I added the SWT.APPLICATION_MODAL style bit to the shell to make the properties window modal, too. In my view this is a common behavior for properties dialogs.

Please consider including the patch.

Thank you for providing jfreechart!

Best regards,
Frank

Discussion

  • hoelle29A
    hoelle29A
    2010-02-09

    shell derived from parent shell

     
    Attachments