Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#864 CandlestickRenderer ignores setBaseCreateEntities(false)

closed-fixed
David Gilbert
General (896)
5
2008-05-13
2008-05-12
David Gilbert
No

Details in this forum post:

http://www.jfree.org/phpBB2/viewtopic.php?t=24596

...copied below:

JFreeChart 1.0.9....
Looking at the source for CandlestickRenderer you can see that the drawItem() method does not check this flag for creating entities and always creates them...
from drawItem() in CandlestickRenderer, line 847 to ...
Code:

// add an entity for the item...
if (entities != null) {
String tip = null;
XYToolTipGenerator generator = getToolTipGenerator(series, item);
if (generator != null) {
tip = generator.generateToolTip(dataset, series, item);
}
String url = null;
if (getURLGenerator() != null) {
url = getURLGenerator().generateURL(dataset, series, item);
}
XYItemEntity entity = new XYItemEntity(body, dataset, series, item,
tip, url);
entities.add(entity);
}

As a note: it would be nice if CandlestickRenderer did like other renderers and moved the generating of entities to a protected method so it could be overriden by extending classes without having to override the whole "drawItem" method.

(It looks like it doesn't check any flags, even the "per series" flags.)

Discussion

  • David Gilbert
    David Gilbert
    2008-05-13

    Logged In: YES
    user_id=112975
    Originator: YES

    Fixed for the upcoming 1.0.10 release.

    Regards,

    Dave Gilbert
    JFreeChart Project Leader

     
  • David Gilbert
    David Gilbert
    2008-05-13

    • status: open --> closed-fixed