#147 Subclipse integration plugin should be available on our update site

open-fixed
Marco Schulze
5
2010-10-16
2009-12-03
jfirechief
No

DO NOT EDIT OR ANSWER THIS ISSUE. SEE THE ORIGINAL ISSUE INSTEAD:
https://www.jfire.org/modules/bugs/view.php?id=1393
ORIGINAL REPORTER: marco

It seems to me the Subclipse integration plugin is missing on our update site. It should be part of the "all in one"-feature.

Once the plugin is part of the regular NightLabs SDK, the followin wiki pages should be updated:

* https://www.jfire.org/modules/phpwiki/index.php/Useful%20Eclipse%20Plugins
* https://www.jfire.org/modules/phpwiki/index.php/Development%20Environment%20Setup

Discussion

  • jfirechief
    jfirechief
    2009-12-03

    • labels: --> NightLabs SDK
     
  • jfirechief
    jfirechief
    2010-10-16

    • assigned_to: nobody --> nlmarco
    • status: open --> open-fixed
     
  • jfirechief
    jfirechief
    2010-10-16

    ORIGINAL COMMENT BY marco, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1393

    If the plug-in would introduce a dependency of the "all in one"-feature to Subclipse, then of course it should become a separate feature. But if it can be added without imposing such a dependency, it would be great to put it into the existing feature.

     
  • jfirechief
    jfirechief
    2010-10-16

    ORIGINAL COMMENT BY marco, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1393

    It's great news that you plan to automate the update site build!

    Even though you personally don't use Subclipse, there are quite a few people who do (including me) and we'll be happy to maintain the plug-in. As I wrote before, it's no problem not to include it in the "all-in-one"-feature, but it should definitely be provided by our update site (as a separate feature).

     
  • jfirechief
    jfirechief
    2010-10-16

    ORIGINAL COMMENT BY Marc, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1393

    The plugin has a subclipse dependency by design an thus will never be part of the all-in-one feature.

    I will not support the plugin as I do not use subclipse and see no need to do so.

    The plugin has to be seen as a community add-on. If someone provides an update-site-ready feature and plugin jar, I will add it to the update site. But I will do no testing or something.

    I plan to automate the update site build. This would be an opportunity to add this plugin to the ci build.

     
  • jfirechief
    jfirechief
    2010-10-16

    ORIGINAL COMMENT BY Marc, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1393

    In order to include the Subclipse plugin, please create a feature base project just as in https://svn.nightlabs.org/svn/main/trunk/org.nightlabs.eclipse.sdk_all-in-one-feature-base. The feature xml here includes plugin entries - these will not be needed in case of the Subclipse plugin. The SDK feature.xml includes them because they are delivered within the target project. Then configure the projects (the fature project and the plugin project) in the product hive in the Development-Update-Site product facet. Use the properties feature=true for the feature project and targetFeature=feature-project-name for the plugin project. Good luck!

     
  • jfirechief
    jfirechief
    2010-10-16

    ORIGINAL COMMENT BY marco, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1393

    The Subclipse integration plugin is now part of the nightly build. I created the feature-project org.nightlabs.eclipse.sdk.subclipse_feature-base and added everything (including 2 binary projects which I needed to fulfill dependencies) to the ProductHive.

    For testing, I uploaded a new build to our experimental update site - http://www.nightlabs.de/updatesites/development-experimental - installed it from there in a fresh Eclipse IDE (with Subclipse, of course) and set up a workspace for JFire-Min 1.1. It works all fine.

    Btw. I had to fix a NPE in org.nightlabs.nightlybuild.tools.AbstractTool line 213 and thus I updated the bundle org.nightlabs.nightlybuild in branches/marc_nightlybuild/target-nightlybuild from 1.3.0 to 1.3.1.