#94 sidekick: fix completionpopup regarding macro recorder

closed-accepted
Eric Le Lay
None
5
2012-03-13
2011-02-07
Eric Le Lay
No

When the Sidekick completion popup is active but no item is selected, and the user types some text, it isn't recorded.
This is only when the option "immediate complete if possible" is disabled,
"show completion popups where possible" is enabled,
"automatic completion popup get focus" is disabled.

I see this with javasidekick and XML plugin :

in XMLPlugin (inspired by https://sourceforge.net/tracker/?func=detail&aid=857802&group_id=588&atid=565475\):
File / New
File / Save c:\temp\1.xml
Macro / Record Temporary Macro

type:
<book>bla</
at this point, the sidekick completion popup shows up, proposing "</book>". Ignore it and continue typing "book>"

Macro / Stop Recording
The macro didn't record anything past "bla<".

In JavaSidekick:
open a java file
Macro / Record Temporary Macro
place the cursor in a method
type "System."
the completion popup appears
continue typing "arraycopy(toto)"
Macro / Stop Recording

Nothing past "System" gets recorded.

With this patch, input typed by the user when the popup menu is active is recorded. Calling TextArea.userInput() doesn't suffice.

Discussion

  • Eric Le Lay
    Eric Le Lay
    2011-02-07

    fix against r19353

     
    Attachments
  • Eric Le Lay
    Eric Le Lay
    2011-07-16

    • assigned_to: nobody --> daleanson
     
  • Eric Le Lay
    Eric Le Lay
    2011-07-16

    Dale, what do you think ?
    Shall I commit it directly ?

     
  • Eric Le Lay
    Eric Le Lay
    2011-10-01

    committed in r20037 (for SideKick 1.3)

     
  • Eric Le Lay
    Eric Le Lay
    2011-10-01

    • assigned_to: daleanson --> kerik-sf
    • status: open --> pending-accepted
     
    • status: pending-accepted --> closed-accepted