#153 XML plugin: fixes for CSS parser

closed-fixed
Dale Anson
None
5
2012-12-28
2012-12-23
Vladimir Avdonin
No

CSS parser for sidekick fails to correctly parse @media and @keyframes rules from CSS3 specification. The example test below generates parsing errors, which are fixed in attached patch. The actual changes were made only to sidekick/css/parser/CSS3Parser.jj file. The following files need to be rebuilt by running javacc target: TokenMgrError.java, ParseException.java, Token.java, SimpleCharStream.java, CSS3ParserTokenManager.java, CSS3ParserConstants.java, CSS3Parser.java.
------------------ test.css -----------------
@media only print and (min-resolution: 240dpi),
only screen and (min-resolution: 240dpi)
{
p {font-size:10px;}
}

@-webkit-keyframes flipouttoleft {
from { -webkit-transform: rotateY(0); }
to { -webkit-transform: rotateY(-90deg) scale(.9); }
}

Discussion

    • labels: --> 826387
     
  • Fix for @media and @keyframes rules parsing

     
  • Alan Ezust
    Alan Ezust
    2012-12-28

    • labels: 826387 -->
     
  • Dale Anson
    Dale Anson
    2012-12-28

    • assigned_to: nobody --> daleanson
     
  • Dale Anson
    Dale Anson
    2012-12-28

    Vladimir, thanks for the patch, looks good! Committed in revision 22627.

     
  • Dale Anson
    Dale Anson
    2012-12-28

    • status: open --> closed-fixed