#149 Outline Plugin : The result of parsing is wrong.

closed-works-for-me
Alan Ezust
None
5
2012-11-04
2012-11-03
funa take
No

Text File
test
test2
test3
test4
test5

Result of parsing (wrong)
root
|-test
|-test2
|-test4

The expected result
root
|-test
| |-test2
|
|-test4

Discussion

  • Alan Ezust
    Alan Ezust
    2012-11-03

    Please attach a test file as an attachment...

     
  • funa take
    funa take
    2012-11-03

    spaces were removed, so I use '_' instead of space.

    Text File
    test
    __test2
    ____test3
    test4
    __test5

    Result of parsing (wrong)
    root
    __|-test
    ______|-test2
    ______|-test4

    The expected result
    root
    __|-test
    __|___|-test2
    __|
    __|-test4

     
  • funa take
    funa take
    2012-11-03

     
    Attachments
  • Alan Ezust
    Alan Ezust
    2012-11-03

    :folding=indent:
    should be at the top of the test.txt file, i believe

     
  • funa take
    funa take
    2012-11-03

    Sample Text

     
    Attachments
  • funa take
    funa take
    2012-11-03

    :folding=indent: is needed
    test.txt file was corrected.

     
  • Alan Ezust
    Alan Ezust
    2012-11-03

    • assigned_to: nobody --> shlomy
     
  • Alan Ezust
    Alan Ezust
    2012-11-03

    Not sure what version your patch was created in, but I tried to apply and i get this:
    patch -p0 < patch.diff
    (Stripping trailing CRs from patch.)
    patching file outline/OutlineAsset.java
    Hunk #1 FAILED at 13.
    1 out of 1 hunk FAILED -- saving rejects to file outline/OutlineAsset.java.rej
    (Stripping trailing CRs from patch.)
    patching file outline/OutlineParser.java
    Hunk #1 FAILED at 39.
    Hunk #2 FAILED at 60.
    2 out of 2 hunks FAILED -- saving rejects to file outline/OutlineParser.java.rej

    please check your patch against outline's svn trunk?

     
  • Alan Ezust
    Alan Ezust
    2012-11-03

    It appears shlomy made some recent changes to Outline which were never officially released. Assigning to him.

     
  • Alan Ezust
    Alan Ezust
    2012-11-03

    • assigned_to: shlomy --> ezust
    • status: open --> pending-works-for-me
     
  • Alan Ezust
    Alan Ezust
    2012-11-03

    Hm! it appears that outline trunk already shows me the expected result. Just tested it with your test file.

     
  • Alan Ezust
    Alan Ezust
    2012-11-03

    Please confirm that trunk is good, and i can make release request.

     
  • funa take
    funa take
    2012-11-04

    Sorry, I was looking at old source.
    The source code of trunk is good.

     
  • Alan Ezust
    Alan Ezust
    2012-11-04

    • status: pending-works-for-me --> closed-works-for-me
     
  • Alan Ezust
    Alan Ezust
    2012-11-04

    Tagged Outline 1.2.4 for release.