#142 BufferList no longer highlighting active filenames

closed-accepted
Gerard
None
5
2012-07-28
2012-07-18
Anonymous
No

In versions newer than 1.1 the filenames which are active in a splitted buffer are no longer highlighted when you click in a splitted buffer frame.
This is a very critical bug. When comparing or updating files in different buffers, vertical or horizontal splitted, you are no longer aware in which file you are editing. This bug makes the great BufferList unusable from jEdit 4.5 on upward to jEdit 5pre.

Discussion

1 2 > >> (Page 1 of 2)
  • Alan Ezust
    Alan Ezust
    2012-07-18

    I am unable to reproduce your bug. What look and feel are you using? I am using plain ol' metal.
    Also, I do not have "enable colorized tabs" checked. What about you?

     
  • Alan Ezust
    Alan Ezust
    2012-07-18

    What version of bufferlist are you using?

     
  • Gerard
    Gerard
    2012-07-19

    I am able to replicate this with BufferList 1.4.

    Open up two files
    Split the view into two editpanes to show each file.
    As you move focus between the two files, the bold highlighting of the current file in the BufferList does not update.

     
  • Alan Ezust
    Alan Ezust
    2012-07-19

    If I click on a *different* (from the one currently open in that splitpane) tab in the buffertabs, I can see this problem as I am switching between editpanes in a split.

    The newly clicked buffertab is what should be bold, and it is not. Instead, the previous editpane's file is still bolded.

    But if all i do is click on the left and then the right splitpanes, if each one is open to a different file, then I do see the correct file being "bolded" each time I switch between panes.
    Furthermore, I also see the correct file being bolded after I invoke the action "go to next text area".

     
  • Gerard
    Gerard
    2012-07-21

    It is interesting that you are seeing different behaviour to me.

    Selecting a third file (not currently visible in the split panes) is the only time the bold highlighting gets updated correctly for me.

    The highlighting doesn't change for me when clicking between splitpanes or using the 'go to next text area' action.

    I noticed you mention BufferTabs, which I dont have installed. Could this make a difference??

    I have tried hacking around, and I think I am able to resolve the problem with the attached patch. This adds listening for the ViewUpdate.EDIT_PANE_CHANGED message, but I am not sure if this is the right approach to take.

    Hopefully this helps anyway.

     
  • Gerard
    Gerard
    2012-07-24

    Sorry if I didn't provide enough details. I was just trying to confirm that I was seeing the same behaviour as the original bug reporter.

    To reproduce it:

    Download latest jedit daily (2012-07-04)
    Run with new settings dir
    Install latest BufferList (1.4) from Plugin Manager
    Dock on left hand side
    Open two different files
    Split the window and show one file in each splitplane
    Change focus between the splitpanes (either by clicking between them or the go to Next/Previous text area actions)
    The current file highlighting on the bufferlist does not update correctly

    The patch I posted previously does seem to resolve this for me, but I don't know enough about the jedit APIs etc to know if this is the best approach to take.

    I hope this helps

     
  • Alan Ezust
    Alan Ezust
    2012-07-24

    moving to patches tracker.
    Gerard, in the future, please open a separate ticket with your patche and make a reference to the bug ID, so we have separate tickets for the bug and the patch. Thanks!

     
  • Alan Ezust
    Alan Ezust
    2012-07-28

    Transmitting file data ..
    Committed revision 21958.

     
1 2 > >> (Page 1 of 2)