Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#135 ErrorList (svn): Set the error name from the path same way

closed-accepted
Alan Ezust
None
5
2012-04-12
2012-04-12
Andy Balaam
No

I noticed that we use 2 different ways to set the DefaultError name from its path in 2 different places.

This patch ensures we always use MiscUtilities.getFileName to do this.

Discussion

  • Andy Balaam
    Andy Balaam
    2012-04-12

    Just in case it's helpful, I have attached a patch combining this and the patch from tracker item 3517170.

     
  • Andy Balaam
    Andy Balaam
    2012-04-12

    Removed patch containing out-dated code.

     
  • Andy Balaam
    Andy Balaam
    2012-04-12

    Sorry, having updated to latest I now see you have fixed the main issue. The replacement patch attached just (hopefully) ensures this won't happen again. Feel free to ignore it if you prefer not to call a setter from the constructor.

     
  • Alan Ezust
    Alan Ezust
    2012-04-12

    I can see that this patch does effectively refactor out one redundant line of code, so in that sense it is not a bad thing to apply, but I can't think of a situation this patch can fix - that is, if there was a problem before with errors not disappearing, I don't see how this can fix it. But thank you for testing my new FileOpenerService! In the future, if you find a bug, please describe detailed steps to reproduce it.

     
  • Alan Ezust
    Alan Ezust
    2012-04-12

    • assigned_to: nobody --> ezust
     
  • Alan Ezust
    Alan Ezust
    2012-04-12

    Committed 21577.

     
  • Alan Ezust
    Alan Ezust
    2012-04-12

    • status: open --> closed-accepted