#112 SVNPlugin : moved import filter to a new file

closed-rejected
Dale Anson
None
5
2012-03-15
2012-03-13
Jarek Czekalski
No

Changed pv.VersionControlState.getFilter() method to make it return null. Moved Project Viewer import filter to a separate class file. That fixed bug #3493305.

Discussion

  • patch file

     
    Attachments
  • Alan Ezust
    Alan Ezust
    2012-03-15

    This patch will have to be revised.
    getFilter() still needs to return a filter. but they should all be shown if no version control service is selected, and the other version control filters should be hidden from the combobox if you pick one of the version control services.
    It looks like marcelo fixed another bug in ProjectViewer that is soon to be pushed.

     
  • Alan Ezust
    Alan Ezust
    2012-03-15

    • status: open --> closed-rejected
     
  • Alan Ezust
    Alan Ezust
    2012-03-15

    Actually, we can reject this. All I need to do is remove the redundant servies.xml entry after PV is fixed.

     
  • So SVN filter will not be available if one does not use the version control.

     
  • Actually it is visible. After the changes to pv. So no problem here.