#101 WhiteSpace patch for #3038126, confusing interface

closed-accepted
None
5
2011-12-02
2011-11-04
Jarek Czekalski
No

I present an option pane for WhiteSpace buffer options. It's placed as the first menu item for this plugin. It's self-explanating and users will stop posting bugs "WhiteSpace not working" :)

I think the old commands may stay as they are, maybe someone likes them. If one wants to switch just one feature, they are faster.

Discussion

  • From what I see, you just added another dialog, containing all the entries from the original whitespace menu, and only added some titles instead of the separators, e.g. "if show spaces is selected ...". My opinion:
    1. It's a waste to have both. If you want to add these labels instead of the separators, do so in the menu.
    2. I'm not sure it will get rid of the bug posts, users may skip the relevant sections of the options and just mark 'show spaces', expecting it to work.

    I think that "spaces" section should be as follows:
    Radio buttons: "Do not show spaces", "Show selected spaces:". The later should have the 3 check-boxes as its children.
    Same for tabs.

     
  • I love discussion! Shlomy, you encouraged me to go further. Your points were really good:
    1. change the order of buttons
    2. add a colon
    I think the type of a box is not important. Check box or radio, they may be both equally confusing. But once the 2 labels and the order of components is changed, it looks ok. Does it for you?

     
  • Now that's much better, though I'd get rid of the original menu items and replace them with the new one that opens the dialog.
    And, either replace all the menu items with this dialog, or only those for which you changed the UI (keeping the fold guides and other stuff in the original menu only). I think it's not a good idea to keep both the original menu and the new dialog.

     
  • Alan Ezust
    Alan Ezust
    2011-11-20

    • assigned_to: nobody --> shlomy
     
  • I would like to commit this additional dialog and you may make further changes if you wish. Is it ok?

     
  • It is okay. I'll probably make some significant changes later:
    1. Make the properties mode-specific - allowing a global default and per-mode overrides. (requested by Alan)
    2. Avoid GUI duplication - same properties accessible via dialog, menu and plugin option pane.
    3. Make it clear how to change settings for the current buffer vs all buffers.

    I also consider the option of implementing a status bar widget to specify the state of the whitespace visibility instead of the menu - just like other meta-data about the current buffer, such as wrap mode.

     
  • Applied and tested finally as r20489.

     
    • status: open --> closed
     
    • status: closed --> closed-accepted