#912 CommonControls 1.7.1

closed
Townsfolk
None
5
2013-10-02
2013-10-01
Alan Ezust
No

{{{ CommonControls 1.7.1
Source: Source code is in SVN under tags/CommonControls-1.7.1
Announcement: Fix #3615050 SmartOpen only lets me type one letter on MacOS L&F.
Added the Blame component. (Dale Anson)
Requires Java 1.6.0
Requires jEdit 05.00.99.00

Short Description: Shared GUI Code

Long Description: The CommonControls plugin provides a set of GUI widgets and classes used in other jEdit plugins.
}}}

Discussion

  • Townsfolk
    Townsfolk
    2013-10-02

    • assigned_to: nobody --> elberry
    • status: open --> pending
     
  • Townsfolk
    Townsfolk
    2013-10-02

    Hey Alan, Getting compile errors while building this.

    Looks like Java 7 code is in there - the use of some Generic Swing stuff:
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:16: type javax.swing.JComboBox does not take parameters
    [jp.javac] public class HistoryComboBox extends JComboBox<String> {
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:18: type javax.swing.DefaultComboBoxModel does not take parameters
    [jp.javac] private DefaultComboBoxModel<String> model;
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/VFSPathFileList.java:59: type javax.swing.JList does not take parameters
    [jp.javac] private JList<String> searchList;
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/VFSPathFileList.java:61: type javax.swing.DefaultListModel does not take parameters
    [jp.javac] private DefaultListModel<String> model;
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:30: cannot find symbol
    [jp.javac] symbol : method setEditable(boolean)
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] setEditable(true);
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:31: type javax.swing.DefaultComboBoxModel does not take parameters
    [jp.javac] model = new DefaultComboBoxModel<String>();
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:47: cannot find symbol
    [jp.javac] symbol : method getSelectedItem()
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] model.addElement(getSelectedItem().toString());
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:51: cannot find symbol
    [jp.javac] symbol : method setSelectedItem(java.lang.String)
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] setSelectedItem("");
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:52: cannot find symbol
    [jp.javac] symbol : method repaint()
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] repaint();
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:56: cannot find symbol
    [jp.javac] symbol : variable super
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] super.processKeyEvent(e);
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:58: cannot find symbol
    [jp.javac] symbol : method fireActionEvent()
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] fireActionEvent();
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:63: cannot find symbol
    [jp.javac] symbol : variable super
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] super.actionPerformed(e);
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:76: cannot find symbol
    [jp.javac] symbol : method getItemCount()
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] while (i < getItemCount()) {
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:78: cannot find symbol
    [jp.javac] symbol : method getItemAt(int)
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] jEdit.setProperty(name + "." + i, getItemAt(i).toString());
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:90: cannot find symbol
    [jp.javac] symbol : method removeAllItems()
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] removeAllItems();
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:95: cannot find symbol
    [jp.javac] symbol : method addItem(java.lang.String)
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] addItem(query);
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/HistoryComboBox.java:100: cannot find symbol
    [jp.javac] symbol : method setSelectedItem(java.lang.String)
    [jp.javac] location: class common.gui.HistoryComboBox
    [jp.javac] setSelectedItem("");
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/VFSPathFileList.java:72: type javax.swing.DefaultListModel does not take parameters
    [jp.javac] model = new DefaultListModel<String>();
    [jp.javac] ^
    [jp.javac] /Users/eberry/dev/myprojects/jedit/plugin-releases/CommonControls-1.7.1/CommonControls/common/gui/VFSPathFileList.java:73: type javax.swing.JList does not take parameters
    [jp.javac] searchList = new JList<String>(model);
    [jp.javac] ^
    [jp.javac] Note: Some input files use unchecked or unsafe operations.
    [jp.javac] Note: Recompile with -Xlint:unchecked for details.
    [jp.javac] 19 errors

    Think the Java requirement needs to be bumped or the use of Generics here removed.

     
  • Alan Ezust
    Alan Ezust
    2013-10-02

    oops. sorry about that. Reverted r23225 on that tag. It should build against 1.6 now.

     
  • Alan Ezust
    Alan Ezust
    2013-10-02

    • status: pending --> open
     
  • Townsfolk
    Townsfolk
    2013-10-02

    • status: open --> closed
     
  • Townsfolk
    Townsfolk
    2013-10-02

    Released to Plugin Central.

     
  • Townsfolk
    Townsfolk
    2013-10-02

    Thanks for the quick fix.