#904 XML plugin: HTML delegates to ecmascript always

closed-fixed
Dale Anson
None
8
2008-08-14
2007-09-07
Alan Ezust
No
0 up votes | 0 down votes | 0%
4 comments

HTML parser should delegate to the preferred javascript sidekick parser for the given mode, so that when people chose the "javascript" sidekick as the preferred javascript parser, it doesn't use ecmascript when parsing HTML.

This is especially important while there are open bugs against the ecmascript parser. I am seriously considering moving it out of the XML plugin and into a standalone class if the memory leaks are not fixed.

Discussion

  • Dale Anson
    Dale Anson
    2007-09-07

    Logged In: YES
    user_id=187628
    Originator: NO

    Unfortunately, I don't have any time to work on anything jEdit related for the next few weeks. I certainly don't have time to delve back into the ecmascript parser to fix the memory leaks, but I might be able to squeeze in a little work on getting the HTML parser to not parse embedded javascript if the ecmascript parser isn't the preferred javascript parser. There is no possibility of delegating to the javascript parser without rewriting the javascript parser, and I don't have time for that right now.

    Alan, if you think it's appropriate to move it back out of XML in the mean time, please go ahead.

     
  • Alan Ezust
    Alan Ezust
    2007-09-07

    Logged In: YES
    user_id=935841
    Originator: YES

    If you can disable the ecmascript parser when something other than ecmascript is the default javascript parser, that would be a sufficient patch that would avoid the need to remove ecmascript from XML.

     
  • Dale Anson
    Dale Anson
    2007-09-09

    Logged In: YES
    user_id=187628
    Originator: NO

    revision 10472 contains a fix so that the html parser only uses the ecmascript parser to parse javascript within an html file if the default javascript parser is set to ecmascript. I didn't have the html parser delegate to the javascript parser since that parser expects to parse a complete buffer rather than a piece of text. I don't have time right now to adjust it to accept less than a full buffer for parsing, so I'll leave this tracker open as a reminder to revisit this when I have more time.

     
  • Dale Anson
    Dale Anson
    2008-08-14

    Logged In: YES
    user_id=187628
    Originator: NO

    I finally found time to fix the javascript parser to be able to handle file fragments. This required changes in both the SideKick plugin and XML plugin, svn revisions 13298 and 13300, respectively. So now the html parser delegates to either the javascript sidekick or the ecmascript sidekick. In the unlikely event someone writes a newjavascript/ecmascript parser, the html parser will need to be changed to be made aware of this new parser.

     
  • Dale Anson
    Dale Anson
    2008-08-14

    • status: open --> closed-fixed