Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#1758 Common Controls - "Close Blame" competes with ColumnRuler

None
closed-fixed
Dale Anson
None
5
2014-06-29
2013-12-07
Robert Schwenn
No

Both the SVN and git plugins provide a Blame action that establishes an area at the right side of text area. At it's top a "Close Blame" button is placed, which seems to be provided by Common Controls plugin. The "Close Blame" button uses the same place as the ColumnRuler plugin to show the ColumnRuler. Now, having enabled both ColumnRuler and Blame there are visibility issues.

Steps to reproduce:
- Enable ColumnRuler visibility
- Enable Blame (SVN or git)
- Go to another open buffer - ColumnRuler isn't shown anymore
- Disable and Re-Enable ColumnRuler visibility - ColumnRuler will be shown
- Go back to the blamed buffer - The "Close Blame" button isn't there
and so on

Discussion

  • Dale Anson
    Dale Anson
    2013-12-07

    I think this should be an easy fix. I thought that the text area was using a BorderLayout for the components around the edges, but in fact, it's using a ScrollPaneLayout, which means the "Close Blame" button can be placed in a corner rather than at the top edge where the ColumnRuler is located.

     
  • Dale Anson
    Dale Anson
    2013-12-07

    • assigned_to: nobody --> daleanson
     
  • Dale Anson
    Dale Anson
    2013-12-07

    Well, I thought this was an easy fix, but the text area is not using a ScrollPaneLayout, it's using a custom ScrollLayout, which doesn't have corners.

     
  • Dale Anson
    Dale Anson
    2014-03-31

    Reminder for when jEdit 5.2 is released -- the patch mentioned above is applied, and I've made small changes to both CommonControls and ColumnRuler to work with the change. Both of these plugins will need to be released after 5.2 is released. The changes can be seen/used now when building jEdit and the plugins from source.

     
  • Dale Anson
    Dale Anson
    2014-03-31

    • status: open --> pending-fixed
    • Group: -->
     
  • Alan Ezust
    Alan Ezust
    2014-04-19

    You can still commit your changes to commoncontrols. I am waiting to test them.

     
  • Alan Ezust
    Alan Ezust
    2014-06-29

    • status: open --> closed-fixed