#525 CompletionPopup should accept TAB for completion selection

None
open
nobody
5
2014-08-25
2013-03-30
Jakub Holý
No

Summary: call "list.setFocusTraversalKeysEnabled(false);" in the constructor of org.gjt.sp.jedit.gui.CompletionPopup to make it possible to use TAB for completion selection, in the same way as ENTER.

This currently doesn't work because TAB is used for component traversal by the focus subsystem and is thus never passed to the JList.

Reference: http://docs.oracle.com/javase/tutorial/uiswing/events/keylistener.html (read the "Version note"

Env.: jEdit 5.0.0, Oracle Java 1.7.0:15 on OS X (though this should apply since JDK 1.4 and to all platforms)

Discussion

  • Hi,

    Patch file attached for the fix as described above.

    Patch generated on trunk on revision 23517.

    Tested:
    OSX 10.8
    java version "1.7.0_40"
    Java(TM) SE Runtime Environment (build 1.7.0_40-b43)
    Java HotSpot(TM) 64-Bit Server VM (build 24.0-b56, mixed mode)

    Cheers

    Cam

     
    Attachments
  • Alan Ezust
    Alan Ezust
    2014-04-25

    Ticket moved from /p/jedit/bugs/3792/

     
  • Alan Ezust
    Alan Ezust
    2014-08-25

    I'm confused. The attached patch does not contain a line that calls
    list.setFocusTraversalKeysEnabled(false) which was the suggestion of the original poster of this ticket. Could you please explain why that is not necessary with this patch?