#513 More robust initialization of LAF

closed-accepted
Dale Anson
None
5
2013-09-26
2013-09-23
Makarius
No

With a fresh build from scratch, e.g. on Mac OS X, startup of jedit.jar produces warnings like this:
"initPLAF failed to set required l&f".

The reason for this is as follows: jEdit property "lookAndFeel" is unset (null), but the system defaults to UIManager.getSystemLookAndFeelClassName, as is correctly determined by jEdit.getPLAFClassName. The subsequent comparison seems to be mangled a bit, though.

The included patch tries to sort this out, using the string class name of jEdit.getPLAFClassName more uniformly.

Discussion

  • Makarius
    Makarius
    2013-09-23

     
    Attachments
    laf
  • Alan Ezust
    Alan Ezust
    2013-09-23

    Nice patch! I'll let your lookandfeel expert review and commit this one though.

     
  • Alan Ezust
    Alan Ezust
    2013-09-23

    • assigned_to: nobody --> daleanson
     
  • Dale Anson
    Dale Anson
    2013-09-23

    I did look at it and it reminded me of another patch that I never got back to. I'll find it and may combine the two since I think they are somewhat similar.

     
  • Dale Anson
    Dale Anson
    2013-09-26

    • status: open --> closed-accepted
     
  • Dale Anson
    Dale Anson
    2013-09-26

    Applied in revision 23214, plus some additional clean up of look and feel initialization. Please check on your Mac that you no longer see the warnings.

     
  • Makarius
    Makarius
    2013-09-27

    Works fine.

    Just note that your SVN revision 23214 re-introduces obsolete "noquartz" stuff by accident that was already removed in revision 23205.

     
  • Dale Anson
    Dale Anson
    2013-09-27

    Thanks for pointing that out. I've removed it again.