#502 Go to offset macro

closed-accepted
Alan Ezust
None
5
2013-08-13
2013-06-21
Thomas Meyer
No

Adds a go to offset macro.

Discussion

  • Thomas Meyer
    Thomas Meyer
    2013-06-21

    v1

     
    Attachments
  • Dale Anson
    Dale Anson
    2013-07-10

    • assigned_to: nobody --> thomasmey
     
  • Dale Anson
    Dale Anson
    2013-07-10

    Thomas, this looks good to me. Feel free to commit it directly to svn.

     
  • Alan Ezust
    Alan Ezust
    2013-08-11

    I have a suggestion on how to improve the macro though:
    You have two strings, a beforelabel and an afterlabel. You would not need 2 of them if you defined a property
    with a parameter {0} in it and then used the jEdit.getProperty(propertyName, argumentList) overload.
    You can see lots of examples of it in jEdit_en.props. This will make localizing your macro a bit easier.

     
  • Alan Ezust
    Alan Ezust
    2013-08-13

    • assigned_to: thomasmey --> ezust
    • status: open --> closed-accepted
     
  • Alan Ezust
    Alan Ezust
    2013-08-13

    I see you just mimic'd an existing macro with that pattern. I guess I should fix that one too...
    But I committed a fixed version of yours. #23111.