#499 Patch for feature request - ID:3605445 (Drag and Drop)

pending-rejected
Alan Ezust
general (64)
5
2013-08-10
2013-05-11
Bence Pinter
No

This patch adds drag and drop functionality to the file browser. DnD happens over the filename column only, so previous functons like selecting multiple files were preserved. Using shift,control,alt over the filename column were also left unchanged.
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
History: https://sourceforge.net/tracker/?func=detail&aid=3605445&group_id=588&atid=350588
https://sourceforge.net/tracker/?func=detail&atid=350588&aid=1910639&group_id=588
https://sourceforge.net/tracker/index.php?func=detail&aid=1910639&group_id=588&atid=350588
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
Issues: dnd uses VFSBrowser.rename(). We found a bug associated with updating the directory structure after moving files (refer: https://sourceforge.net/tracker/?func=detail&aid=3613115&group_id=588&atid=100588\). It was there before, but our patch uses that function more often.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Made by: Bence Pinter, Laszlo Schmidt, Zsombor Franczia

Discussion

  • Bence Pinter
    Bence Pinter
    2013-05-11

    added a new class to the browser package (DragAndDropHandler.java, + one line to BrowserView.java)

     
  • Alan Ezust
    Alan Ezust
    2013-08-10

    nice! But if I am holding the "ctrl" key, it doesn't copy the file, it still moves it.

     
  • Alan Ezust
    Alan Ezust
    2013-08-10

    it should change the icon to a + sign and copy instead of move when the user has the ctrl-key held down.

     
  • Alan Ezust
    Alan Ezust
    2013-08-10

    • status: open --> pending-remind
     
  • Alan Ezust
    Alan Ezust
    2013-08-10

    • status: pending-remind --> pending-rejected
     
  • Alan Ezust
    Alan Ezust
    2013-08-10

    This patch changes the way multiple selection works in the file system browser.
    Before, I could click+drag to select multiple files and perform operations on them as a group.
    Now I can't, because the drag handler kicks in before I have finished making my selection.

    Also, it seems to work with only a single selection.
    please fix these issues and submit again - it is a nice start.

     
  • Alan Ezust
    Alan Ezust
    2013-08-10

    • assigned_to: nobody --> ezust