Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#470 Enhance Task with Runnable

pending-invalid
Alan Ezust
None
5
2013-06-30
2012-11-17
Thomas Meyer
No

Enhance Task with a Runnable which will be run on the EDT after the task finishes successfully and convert some users of org.gjt.sp.util.AwtRunnableQueue.runAfterIoTasks(Runnable) to use this mechanism instead.

The idea is to get rid of the AwtRunnableQueue in the long term. And to couple the Runnable which should be run after a background task finishes to the background task itself.

Feedback is welcome on this idea.

Discussion

<< < 1 2 3 > >> (Page 2 of 3)
  • Thomas Meyer
    Thomas Meyer
    2013-04-13

    So some code, please have a look and tell me what do you think about the direction this is heading!

    "But in that case it would have the same behavior as we had before, when an AWT task is running, no other task can be started ?" -> The current implementation allows several task to run. Or am I missing something?

    This patch is based on the refactor IoTask patch.

     
  • Alan Ezust
    Alan Ezust
    2013-04-13

    so to clarify, do I need to apply 3 patches in this order to test this ticket?
    1. the patch from ticket# 3610167,
    2. the patch below that is for refactoring IO tasks
    3. the Replace-WorkThreadPool-with-executor.patch

    Just tried applying them to trunk, each of them has a couple of hunks that fail, and #3 had 4 hunks that failed.

     
  • Thomas Meyer
    Thomas Meyer
    2013-04-14

    Hi,

    my current patch queue is:
    $ hg qseries
    Fix-Hypersearch-Excessive-Mode-Usage.patch
    HyperSearch-Make-Abort-work-reliable.patch
    TaskManager-Refactor-ioTask.patch
    TaskManager-Refactor-AwtTask-IoTask.patch

    But you should actullally just need these two:
    - TaskManager-Refactor-ioTask.patch (from 3610167)
    - TaskManager-Refactor-AwtTask-IoTask.patch (from this one)

    TaskManager-Refactor-ioTask.patch seems to not apply cleanly on the trunk, because of the other ones in the queue. Shall I rework the patch to apply cleanly? Or can we get the other two applied to the trunk first?

    The third patch is not needed anymore (Replace-WorkThreadPool-with-executor.patch) as it becomes obsolet with the new idea in "TaskManager-Refactor-AwtTask-IoTask.patch". Shall I remove the file from this side?

     
  • Alan Ezust
    Alan Ezust
    2013-04-15

    I don't know what ticket# the Fix-Hypersearch-Excessive-Mode-Usage.patch is in.
    Tried to apply HyperSearch-Make-Abort-work-reliable.patch and failed.
    You ask: "Shall I rework the patch to apply cleanly? Or can we get the other two applied to the trunk first?"
    I would be happy if either or both things happened.

    In general, if your patch depends on another ticket to be applied first, you should list the ticket number there, to help us figure things out faster.

     
  • Alan Ezust
    Alan Ezust
    2013-06-07

    • assigned_to: kpouer --> ezust
     
  • Alan Ezust
    Alan Ezust
    2013-06-09

    • status: open --> open-remind
     
  • Alan Ezust
    Alan Ezust
    2013-06-09

    I can apply the patch cleanly but I get a compile error on buffer.java:307 cannot find symbol getIoTask()

     
<< < 1 2 3 > >> (Page 2 of 3)