#452 Enable ContextMenu via keyboard to VFS-BrowserView

closed-accepted
Alan Ezust
None
5
2012-08-21
2012-08-21
Thomas Meyer
No

Enable the usage of the context menu key to work in the VFS BrowserView.

Discussion

  • Alan Ezust
    Alan Ezust
    2012-08-21

    • assigned_to: nobody --> ezust
     
  • Alan Ezust
    Alan Ezust
    2012-08-21

    • status: open --> closed-accepted
     
  • Alan Ezust
    Alan Ezust
    2012-08-21

    Committed 22037. Thanks again!

     
  • Thomas Meyer
    Thomas Meyer
    2012-08-22

    Looking at this patch again I wonder if the actions done in the KeyListener must be wrapped in an invokeLater() call to be guaranteed to run in the Event Dispatch thread? Can any WindowToolkit comment on this please?

     
  • Alan Ezust
    Alan Ezust
    2012-08-22

    you should ask this on jedit-devel, not as a comment to this ticket.
    I am not sure what the answer is to your question, but when you know, you can commit directly your fix to svn.

     
  • Keyboard and MouseEvents are always executed from dispatch thread by the JVM, so the only reason why you would use an invokeLater here is if you want that your actions are done after the event handling and maybe a repaint. But I don't think it is necessary.