#427 Enhance SearchDialog with disable undo flag

pending
None
5
2013-07-01
2012-05-25
Thomas Meyer
No
0 up votes | 0 down votes | 0%
6 comments

Enhance the SearchDialog with an option to disable the undo for search&replace-all operations. This enables jEdit to successfully search&replace larger text files without getting an OOM error.

Discussion

  • Alan Ezust
    Alan Ezust
    2012-08-22

    I think you may need to rebase this patch off the current trunk,
    [ezust@cerberus] /home/ezust/workspace/jedit/trunk> patch -p0 < jEdit-disableUndo-for-searchandreplace-all.patch
    patching file org/jedit/localization/jedit_en.props
    Hunk #1 FAILED at 849.
    1 out of 1 hunk FAILED -- saving rejects to file org/jedit/localization/jedit_en.props.rej
    patching file org/gjt/sp/jedit/search/SearchAndReplace.java
    patching file org/gjt/sp/jedit/search/SearchDialog.java
    patching file org/gjt/sp/jedit/buffer/JEditBuffer.java
    Hunk #1 succeeded at 2268 (offset -161 lines).
    patching file org/gjt/sp/jedit/buffer/UndoManager.java
    Hunk #1 FAILED at 164.
    Hunk #2 FAILED at 205.
    Hunk #3 succeeded at 276 (offset -1 lines).
    Hunk #4 succeeded at 707 with fuzz 2 (offset 208 lines).
    2 out of 4 hunks FAILED -- saving rejects to file org/gjt/sp/jedit/buffer/UndoManager.java.rej

     
  • Thomas Meyer
    Thomas Meyer
    2012-08-22

    This is actually the broken out patch of point 3.) from patch 3528205.

    First we should clarify if this option is still wanted. If yes I can do a rebase in the next days.

     
  • Alan Ezust
    Alan Ezust
    2012-08-22

    • assigned_to: nobody --> k_satoda
     
  • Alan Ezust
    Alan Ezust
    2013-02-07

    • assigned_to: k_satoda --> kpouer
     
  • Hi,
    instead of an option that the user would select (and on which criteria, users don't expect to get OOM), why not catching the OOM, and when it happens open a dialog to ask the user if he want's to continue without any undo ? (I think Ultraedit does something like that)

     
    • status: open --> pending