#252 updated edit mode for SAS

closed-accepted
Alan Ezust
None
5
2009-06-29
2009-05-18
goebbe
No

The attached file contains a small update for the latest version of SAS edit mode that has been updated by ezust in revision 15306.

The update only concerns range comments that start with * and that end with ;
Previous versions (revision 15306) did not allow rows of these range comments. The new version allows up to two range comments of these type in a row - this is likely to cover all common use-cases.

In order to implement this I define a new comment2 that defines a "full range-comment plus the start of the second range comment" as the beginning of the second range comment.
This is the first time that I use regexp seriously - so please check carefully.

I will also attach a file with testcases that are now all covered.

Note that I do not intend to implement more than two comment2 range comments in a row since this seems not worth the effort - and computation time.

Discussion

  • goebbe
    goebbe
    2009-05-18

    SAS edit-mode that allows for two comment2; comment2; in a row

     
    Attachments
  • goebbe
    goebbe
    2009-05-18

    testcases for comment2 range comments

     
    Attachments
  • goebbe
    goebbe
    2009-05-19

    Seems that the first version did no cover the case of two range comments at the start of a line. The new upload fixed this.

     
  • goebbe
    goebbe
    2009-05-19

    SAS edit mode - that also allows comment2; comment2; at the start of a line

     
    Attachments
  • goebbe
    goebbe
    2009-05-19

    extended set of tests for comment2 range comments

     
    Attachments
  • goebbe
    goebbe
    2009-05-19

    O.k. now I also checked some rather complicated real-world examples - and I did not
    find any issues.

    @ezust: I suggest to submit this version to complete the clean up of the SAS-edit mode.

     
  • goebbe
    goebbe
    2009-05-19

    • assigned_to: nobody --> ezust
     
  • goebbe
    goebbe
    2009-05-20

    extended set of tests version 0.3

     
    Attachments
  • goebbe
    goebbe
    2009-06-29

    @ezust:
    The remaining cases in attached sas_comment_test.sas file cannot be covered easily within Jedit.
    Since the latest version of sas.xml fixes most of the missing cases at least compared to the version that is currently in svn I suggest to apply the changes.

     
  • Alan Ezust
    Alan Ezust
    2009-06-29

    Transmitting file data .
    Committed revision 15611.

     
  • Alan Ezust
    Alan Ezust
    2009-06-29

    • status: open --> closed-accepted