#8 Do not send PROPERTIES_CHANGED for temporary buffers

for 4.3.x
closed-accepted
Dale Anson
None
5
2010-05-08
2010-02-02
No

Hi, I think we should merge this patch
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2932330&group_id=588
It was committed in rev 17145

Discussion

  • Is there anything bad caused by sending PROPERTIES_CHANGED for temporary
    buffers.

     
  • Dale Anson
    Dale Anson
    2010-04-18

    The only bad thing is a performance hit. In the case of the TaskList plugin, which is what caused this issue to be discovered, it is possible for literally thousands of such messages to be sent on the edit bus in a very short period of time. This makes for an unnecessary performance hit. Further, many plugins react to each property changed message by reloading and reapplying their properties, which further adds to the performance hit.

     
  • Dale Anson
    Dale Anson
    2010-05-01

    • assigned_to: nobody --> daleanson
     
  • Dale Anson
    Dale Anson
    2010-05-01

    Committed in revision 17716.

     
  • Dale Anson
    Dale Anson
    2010-05-01

    • status: open --> closed-fixed
     
    • status: closed-fixed --> closed-accepted
     
  • r17716 was reverted at r17763 since it was not a merge from trunk and it
    included some fractional changes.

    The fractional changes was committed into trunk at r17762. And finally,
    the all changes are merged at r17764.