#174 fix keymap duplication

for 5.0.x
closed-accepted
Alan Ezust
None
5
2012-10-15
2012-09-28
Björn Kautler
No
0 up votes | 0 down votes | 0%
5 comments

r22265

Discussion

  • also merge 22350 for coding style

     
  • Björn Kautler
    Björn Kautler
    2012-10-11

    Ah, my fault, sorry.
    Thanks for fixing

     
  • Alan Ezust
    Alan Ezust
    2012-10-13

    What is the bug that this fixes? Steps to reproduce?

     
  • Björn Kautler
    Björn Kautler
    2012-10-14

    Actually there are two and a half issues that were solved with this change.

    1.) If you duplicate a keymap and specify a name that alredy exists, the label of the dialog is empty as the property was wrongly named

    2. and half) If you cancel the first dialog, or the dialog that is shown if you specified a duplicate name, then the process was not cancelled, but a keymap with name "null" was added as the return value of showInputDialog(...) was not checked in both cases.

     
  • Alan Ezust
    Alan Ezust
    2012-10-15

    Committed 22379.

     
  • Alan Ezust
    Alan Ezust
    2012-10-15

    • assigned_to: nobody --> ezust
    • status: open --> closed-accepted