Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#144 Wrong Chars in Auxiliary Fonts

for 4.5.x
closed-rejected
None
5
2012-03-09
2012-03-09
Alan Ezust
No

Related tickets: #3474765, #3474534, #3480246

Please merge rev# 20941 and 20969 into 4.5.x to display correct characters for font substitution.
Thanks to Max Funk!

Discussion

  • Alan Ezust
    Alan Ezust
    2012-03-09

    Perhaps also rev21212, related to ticket 3488967 but also related to font glyph substitution can be included in this ticket, or do I need to make a new ticket for that?

     
  • Alan Ezust
    Alan Ezust
    2012-03-09

    • summary: Wrong Chars in Auxilary Fonts --> Wrong Chars in Auxiliary Fonts
     
    • assigned_to: nobody --> k_satoda
     
  • I was considering about merging further series of fixes for font
    substitution.

    Here are my conclusions:

    r20941
    This is the minimal fix to make font substitution work on code
    points instead of code units, and resolve dependency for r21259 in
    merge request #3498696.
    So this one should be merged separately.

    r20969
    This avoid font substitution for control chars which could result
    in improper glyphs with some buggy fonts which says it can display
    such control chars. This is a workaround for a minor problem.
    So this one should be merged separately, not to complicate others.
    However, since this one is nominated in this merge request, I'll
    accept it but in separate revision.

    * Above here, svn merge just works.

    r21212
    This is a quality improvement for the cases where both an auxiliary
    font and the default font can display chars after first char which
    triggered font substitution.
    But this fix depends on r21205 which requires manual resolution of
    merge conflicts. This also means that merge request for r21212 will
    need a backport branch.
    I may post a merge request later if I can resolve the conflict
    cleanly. I think this is not required to be in 4.5.1.

     
  • From my last comment,
    > r20969
    (snip)
    > So this one should be merged separately, not to complicate others.
    > However, since this one is nominated in this merge request, I'll
    > accept it but in separate revision.

    I turn down this decision about separation. The entry in CHANGES.txt;
    "Wrong chars in auxiliary fonts" told me that these can be said as a
    single fix for users. It's enough to have separate revisions in trunk.

     
  • Reviewing the diff of r20941, I noticed that the quality problem which
    was fixed in r21212 was a regression since r20941, which had
    accidentally dropped the check to switch back to the default font.
    http://jedit.svn.sourceforge.net/viewvc/jedit/jEdit/trunk/org/gjt/sp/jedit/syntax/Chunk.java?r1=20941&r2=20940#l574

    Then we can't accept r20941 without the fix in r21212.

    Now it turns out that the whole revisions, r20941,20969,21205,21212, are
    linked in a single chain of dependencies.

    I'll post a merge request for these with a backport branch. This request
    is rejected.

     
    • status: open --> closed-rejected