From: SourceForge.net <no...@so...> - 2010-10-21 21:20:44
|
Patches item #3083902, was opened at 2010-10-08 12:39 Message generated for change (Comment added) made by daleanson You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3083902&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: texteditor Group: None Status: Open Resolution: None Priority: 7 Private: No Submitted By: Ollie Rutherfurd (orutherfurd) Assigned to: Dale Anson (daleanson) Summary: NPE if mode has no FILE_NAME_GLOB Initial Comment: I've got modes that don't have a FILE_NAME_GLOB (which I believe is optional) in catalog. jEdit dies during startup with an NPE on line 263 of Mode.java. This appears to have been introduce in revision18093. The attached patch fixes it by swapping the comparison (filename.equals(null) vs null.equals(filename)). ---------------------------------------------------------------------- >Comment By: Dale Anson (daleanson) Date: 2010-10-21 15:20 Message: Applied to trunk in revision 18809. Leaving this open until it is applied on the 4.4.x branch. ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2010-10-11 09:58 Message: I also have modes that don't have a FILE_NAME_GLOB, but I don't see the error. jEdit starts fine. Your patch looks good, though, it just concerns me that I can't reproduce this. Would you mind attaching your catalog file? ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2010-10-11 09:23 Message: I committed revision 18093, so I'll take a look at this one. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3083902&group_id=588 |