Re: [ jEdit-devel ] Leaking VIew (and dockable) instances?

[Shlomy R. <sre...@gm...>]

Hi,
I did try "Show Nearest GC Root", but I didn't understand what it did.
In JProfiler, this should you a path in the reference graph that you
can easily recognize.
Shlomy

On Sun, Jan 24, 2010 at 4:41 PM, Kazutoshi Satoda
<k_s...@f2...> wrote:
> Shlomy Reinstein wrote:
>>
>> I reproduce it consistently on Windows XP with Java 1.6.0_18. After
>> creating and immediately closing 2 views, visual vm shows me that the
>> 3 view objects are still alive. It might be OS / Java-version
>> dependent.
>
> Why don't you try "Show Nearest GC Root" then?
>
> Now I found that an EditPane is held in the global bufferSet as a
> listener. The attached patch will eliminate the leak.
>
> I'll create another branch from 4.3.x to make a merge request for this
> fix.
> ... Oh, I found that current release-procedure accept fixes only from
> the trunk. I'll first fix it, too.
> --
> k_satoda
>
> Index: org/gjt/sp/jedit/EditPane.java
> ===================================================================
> --- org/gjt/sp/jedit/EditPane.java      (revision 17057)
> +++ org/gjt/sp/jedit/EditPane.java      (working copy)
> @@ -950,6 +950,7 @@
>        {
>                saveCaretInfo();
>                EditBus.send(new
> EditPaneUpdate(this,EditPaneUpdate.DESTROYED));
> +               bufferSet.removeBufferSetListener(this);
>                EditBus.removeFromBus(this);
>                textArea.dispose();
>        } //}}}
>
>