[ jEdit-commits ] SF.net SVN: jedit:[16978] plugins/SideKick/trunk/sidekick

[<dal...@us...>]

Revision: 16978
          http://jedit.svn.sourceforge.net/jedit/?rev=16978&view=rev
Author:   daleanson
Date:     2010-01-19 23:52:52 +0000 (Tue, 19 Jan 2010)

Log Message:
-----------
Added some TODOs.

Modified Paths:
--------------
    plugins/SideKick/trunk/sidekick/SideKickOptionPane.java
    plugins/SideKick/trunk/sidekick/SideKickTree.java

Modified: plugins/SideKick/trunk/sidekick/SideKickOptionPane.java
===================================================================
--- plugins/SideKick/trunk/sidekick/SideKickOptionPane.java	2010-01-19 23:39:27 UTC (rev 16977)
+++ plugins/SideKick/trunk/sidekick/SideKickOptionPane.java	2010-01-19 23:52:52 UTC (rev 16978)
@@ -35,7 +35,7 @@
 
 public class SideKickOptionPane extends AbstractOptionPane
 {
-	//{{{ GeneralOptionPane constructor
+	//{{{ SideKickOptionPane constructor
 	public SideKickOptionPane()
 	{
 		super("sidekick");
@@ -44,8 +44,6 @@
 	//{{{ _init() method
 	protected void _init()
 	{
-	//	addSeparator("options.sidekick.general.label");
-		
 		addComponent(showToolTips = new JCheckBox(jEdit.getProperty(
 			"options.sidekick.showToolTips.label")));
 		showToolTips.setSelected(jEdit.getBooleanProperty(
@@ -64,7 +62,7 @@
 		scrollToVisible.setSelected(jEdit.getBooleanProperty(
 			"sidekick.scrollToVisible"));
 		
-		// TODO: add checkbox to show/hide filter here, indent next 2 checkboxes
+		// checkbox to show/hide filter, indent next 2 checkboxes
 		addComponent(showFilter = 
 			     new JCheckBox(jEdit.getProperty("options.sidekick.showFilter.label", "Show filter text box")));
 		showFilter.setSelected(jEdit.getBooleanProperty(SideKick.SHOW_FILTER, true));
@@ -86,9 +84,11 @@
 		persistentFilter.setSelected(jEdit.getBooleanProperty("sidekick.filter-visible-assets"));
 		addComponent(filterOptionPanel);
 		
+		
 		addComponent(jEdit.getProperty("options.sidekick.auto-expand-tree-depth"),
 			autoExpandTreeDepth = new JComboBox());
 		autoExpandTreeDepth.addActionListener(new ActionHandler());
+		// TODO: put "All" in properties file
 		autoExpandTreeDepth.addItem("All");
 		for (int i = 0; i <= 10; i++)
 			autoExpandTreeDepth.addItem(String.valueOf(i));
@@ -133,8 +133,6 @@
 
 		parsingSettings.add(new JLabel(jEdit.getProperty("options.sidekick.auto-parse-delay")), BorderLayout.CENTER);
 		parsingSettings.add(autoParseDelay = new JSlider(200,3000,autoParseDelayValue), BorderLayout.SOUTH);
-		/*addComponent(autoParseDelay = new JSlider(200,3000,autoParseDelayValue),
-			GridBagConstraints.BOTH); */
 		addComponent(parsingSettings);
 		Hashtable labelTable = new Hashtable();
 		for(int i = 500; i <= 3000; i += 500)
@@ -221,6 +219,7 @@
 		jEdit.setBooleanProperty("sidekick.filter-visible-assets", filterVisibleAssets.isSelected());
 		int depth = 0;
 		String value = (String)autoExpandTreeDepth.getSelectedItem();
+		// TODO: see above, "All" should be in the properties file
 		depth = value.equals("All") ? -1 : Integer.parseInt(value);
 		jEdit.setIntegerProperty("sidekick-tree.auto-expand-tree-depth",
 			depth);

Modified: plugins/SideKick/trunk/sidekick/SideKickTree.java
===================================================================
--- plugins/SideKick/trunk/sidekick/SideKickTree.java	2010-01-19 23:39:27 UTC (rev 16977)
+++ plugins/SideKick/trunk/sidekick/SideKickTree.java	2010-01-19 23:52:52 UTC (rev 16978)
@@ -91,6 +91,8 @@
 
 /**
  * The Structure Browser dockable.  One instance is created for each View.
+ * TODO: Fix focused component: if filter text area is visible, it gets the
+ * initial focus, otherwise, the tree gets the initial focus.
  */
 public class SideKickTree extends JPanel implements DefaultFocusComponent
 {
@@ -365,7 +367,7 @@
 
 			keys.pop();
 		} else {
-			Log.log(Log.DEBUG, this, "addData called on a node that isn't a treenode!!!!!!!!!");
+			Log.log(Log.DEBUG, this, "addData called on a node that isn't a treenode!!!!!!!!!"); // how exciting!
 		}
 	} //}}}
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.