[ jEdit-devel ] [ jedit-Plugin Patches-1859034 ] Console: Enable "Subshell extra PATH"

[SourceForge.net <no...@so...>]

Plugin Patches item #1859034, was opened at 2007-12-28 03:30
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=1859034&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: Kazutoshi Satoda (k_satoda)
Assigned to: Nobody/Anonymous (nobody)
Summary: Console: Enable "Subshell extra PATH"

Initial Comment:
I found that the option "Subshell extra PATH" was completely not working
while looking the source code. The property "console.shell.pathdirs" was
used only at ProcessRunner#prependUserPath(), and the method was called
only from GeneralOptionPane#_save(). It was not used at all on normal
use of Console.

This patch enables the option.


Some notes about changes.

Upcasing names of environment variables for Windows were dead codes. Now
it works as the code looks. But this may be a user visible change. For
example, setenv("Path", ...) no longer works. It must be written as
setenv("PATH", ...) instead.

ProcessRunner.Windows9x has its own exec() method. It is not an overload
because the type of argument env is different. I can't find any caller
of this method. Could it be removed?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=1859034&group_id=588