Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-1588994 ] JImporter fix for "Import class at point"
|
From: SourceForge.net <no...@so...> - 2006-11-02 21:39:02
|
Patches item #1588994, was opened at 2006-11-01 17:02 Message generated for change (Comment added) made by ezust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1588994&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Byron (bhawkins1) Assigned to: Nobody/Anonymous (nobody) Summary: JImporter fix for "Import class at point" Initial Comment: The current distribution of JImporter fails to recognize the word at the caret if the caret is at the beginning or end of the word. Maybe this is caused by a setting or something--I don't really care. In my opinion the plugin is fatally broken, and should not be distributed in this condition. The attached jar consists of the latest release of JImporter (version 0.4.0) with two changes: 1) jimporter.JEditClassImporter.getWordAtPoint(View) is re-implemented with a working algorithm. 2) jimporter.JEditClassImporter.importClass(View, String) is public, so that other people in the world (yes, there *are* other people in the world) can write macros to import stuff. I don't know if I am submitting this jar in the right place. Since I cannot figure out the proper procedure by reading what is on these jEdit and related sourceforge websites, I am submitting the jar here. That is all I will do with it. Take it if you like it. Otherwise, don't bother me about it. It was dead-broken when I got it! ---------------------------------------------------------------------- >Comment By: Alan Ezust (ezust) Date: 2006-11-02 13:38 Message: Logged In: YES user_id=935841 moving this to the patches tracker... ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2006-11-02 13:36 Message: Logged In: YES user_id=935841 If you are going to continue working on it, please check out a copy from CVS and apply your changes directly. I just added you as a developer, so you can commit to the jimporter plugin. Nobody else has worked on it in a long time. I prefer that, or else submitted patches via the patches tracker, to a big tarball as an attachment on the tracker item. Also, normalyl we don't create "plugin submissions" until the thing is already committed to CVS/SVN and tagged. ---------------------------------------------------------------------- Comment By: Byron (bhawkins1) Date: 2006-11-02 13:05 Message: Logged In: YES user_id=1252914 I'm still using 4.2 because when I install 4.3 it throws a lot of exceptions, and none of the text is visible (though the caret positions are all intact). It would take me a while to get familiar with 4.3 and JavaSideKick and all the other new stuff. That is probably more effort than I can offer at the moment. The current version of JImporter recognizes my classpath, though I can't say offhand where it has found it. I use a personal plugin for compiling (which invokes ant thru the system) because I could never get the 4.2 built-in stuff or the JCompiler plugin to do work. Dunno where to go with this regarding 4.3. I've patched up the options dialog and am working on the sorting algorithm, which is dog slow. The new version will use java.util.regex, and will implement the whitespace feature for auto-sorting and whatever else seems convenient. It seems to me that anything I work on can be easily applied to 4.3, as long as I stay out of the "find class with this name" functionality. In general, I'm happy to go about this in whatever way is best for the project, but I'm not willing to be responsible for figuring out what that is. If anyone wants me to do something in particular with this plugin, tell me what to do and how to do it. Otherwise I'll just do things my own way. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2006-11-01 22:31 Message: Logged In: YES user_id=935841 It has no proper option pane, nor menu, nor help. It hasn't been updated to use the 4.1 API much less the 4.2 API. It would be just as easy to merge it into the JavaSideKick as it would be to update it to the newer API, I think... ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2006-11-01 22:12 Message: Logged In: YES user_id=935841 Thanks for your submission! JImporter is aware of classpaths for SpeedJava and JCompiler, but not JavaSideKick (via projectviewer). I'll release this version for the 4.2 final branch, but shouldn't this plugin eventually be merged with JavaSideKick in some way? ---------------------------------------------------------------------- Comment By: Byron (bhawkins1) Date: 2006-11-01 17:12 Message: Logged In: YES user_id=1252914 Oops, there was an off-by-one in the algorithm that identifies the word at the caret. That is fixed in this attached file. Sorry to double-post this. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1588994&group_id=588 |