RE: [ jEdit-devel ] 3.2pre6 two bugs

[John G. <jge...@ny...>]

> > > > 1) Global Options>Shortcuts: I could specify a shortcut that already
> > > > existed (C+t).
> > > > Isn't the code preventing duplicate shortcuts already in?
> > > I've disabled it for now and left it until 4.0. See the
> comments in the
> > > code why.
> >
> > I see. Wouldn't it be a good solution if
> > a) the three shortcut panes get integrated into one, with three
> tabs on a
> > JTabbedPane, and
> > b) a Vector containing the three ShortcutsModels is passed to
> > GrabKeyDialog,
> > so that it gan check for existing shortcuts?
> >
> > Dirk.
> >
>
> An integrated GUI might be good for organizing shortcuts but is
> unnecessary
> for duplicate shortcut checking. The patch I sent runs the
> keycombo through
> jEdit's input handler to see if an action is already attached.  Right now
> the checking routine only handles single keypresses (which is why Slava
> disabled it).
>
> John

I haven't finished my mrning coffee, so I had forgotten why the patch was
disabled.  It does handle multiple key strokes.  Here's Slava's explanation
from the source code:

// this doesn't work properly if changes have already
// been made to the shortcuts, because the input
// handler is only updated after the options dialog
// is closed...

John