Menu

#493 Undo "Close all buffers"

none
closed-fixed
None
5
2016-05-04
2007-11-09
No

"Close all buffers" should ask for confirmation, because it's annoying if a huge list of opened files get closed by accident ("Close all buffers" (C-e C-w) has nearly the same shortcut as "Mark word at cursor" (C-e w). But it could also happen by accidently clicking the action menu entry)

An option for this could make sense, just like the already existing "'Save all buffers' asks for confirmation" (which resides in "Saving & Backup").
I don't know where the new option should get put though. Maybe a new tab "Confirmations"?

Discussion

  • Kazutoshi Satoda

    Logged In: YES
    user_id=1483238
    Originator: NO

    This request is for confirmation before closing any buffer, not before
    closing each buffer. It looks a valid request.

     
  • daniel hahler

    daniel hahler - 2009-03-18

    I'm moving this to the Bugs tracker (instead of feature request), now that it happened again to me (and I'm used to have a lot of buffers open, switching with the "Switch Buffer" plugin between them).

    For now, I've removed the "Close all buffers" shortcut in my settings.

    Still, a confirmation dialog seems the way to fix/prevent this.
    Additionally, I would say that "Close all buffers" either should not have a default shortcut or another/safer one (even when the confirmation dialog gets added).

     
  • daniel hahler

    daniel hahler - 2009-03-18
    • labels: 871558 -->
     
  • Eric Le Lay

    Eric Le Lay - 2013-01-17

    A "reopen last closed" action would be more desirable to me, like using Ctrl-Shift-T in web browsers, but I don't think we have the information to do so (list of recently closed, buffersets they were part of, etc.).

     
  • Alan Ezust

    Alan Ezust - 2014-12-30
    • summary: Please add confirmation for "Close all buffers" --> Undo "Close all buffers"
    • Group: --> minor bug
     
  • Alan Ezust

    Alan Ezust - 2014-12-30

    Ticket moved from /p/jedit/bugs/2982/

     
  • Eric Le Lay

    Eric Le Lay - 2015-01-03

    I've written a plugin to do this some time ago but never released it.
    See Reopen.

    It restores the buffer set and the buffer contents.

     
  • Alan Ezust

    Alan Ezust - 2015-01-03

    Testing it now. Others can download a pre-release here:
    http://lazarus.oddiofile.com/jars/Reopen.jar

    It seems to work on first try. Small suggestions.

    1. changing the .menu into a .menu-item
    2. changing "reopen closed file" to "reopen closed files"
    3. Adding a small documentation page.

    It might be ready for release after that.

     
  • Eric Le Lay

    Eric Le Lay - 2015-01-03

    I have
    [AWT-EventQueue-0] [error] ReopenPlugin: couldn't find the buffer closing in given view
    messages in the activity log.

    Looks like the buffer has already disappeared from the edit panes/buffersets upon the BufferUpdate event.

     
  • Eric Le Lay

    Eric Le Lay - 2015-01-03

    There is a bug in Reopen plugin: once the limit of buffers to remember (10) is reached, closing a buffer removes the most recently closed buffer, not the oldest. I'll correct that.

     
  • Alan Ezust

    Alan Ezust - 2015-01-04

    Daniel:

    Regarding the shortcut you didn't like/changed, the person who came up with the "jedit" keymap is Slava, and he doesn't even use jEdit anymore. Nobody is maintaining the default keymap and the only reason it's there is because it never changes and is something people can "count on". Changing it to anything now seems pointless. It is not maintained.

    If you want to make changes to the German keymap, that is another story. Feel free to make any changes you think are appropriate.

    or, if you have another keymap you think is worthy of sharing with the community, feel free to submit it. You are a very experienced jEdit user so I don't doubt you can come up with something better than jEdit.keymap.

    I am the one responsible for the Emacs.keymap so if you have complaints about that, you can send them to me.

     

    Last edit: Alan Ezust 2015-01-04
  • Alan Ezust

    Alan Ezust - 2015-01-04

    Eric: If you move Reopen to jEdit's sf.net git, I will see the change notifications as e-mails and know when to do a pull.

     
  • Eric Le Lay

    Eric Le Lay - 2015-01-04

    I've corrected most bugs, updated the doc and put a new version at http://kerik-sf.users.sourceforge.net/dropbox/Reopen.jar

     
  • Eric Le Lay

    Eric Le Lay - 2015-01-04

    I mean every bug that I could find.
    And we'll move to jEdit git ASAP.

     
  • Dale Anson

    Dale Anson - 2015-08-09

    What's the status on this? The Reopen plugin seems to work well. How about putting in a release request and closing this ticket?

     
    • Eric Le Lay

      Eric Le Lay - 2015-08-10

      release request created.
      Thanks for the reminder :-)

       
  • Dale Anson

    Dale Anson - 2016-05-04
    • status: open --> closed-fixed
    • assigned_to: Dale Anson
    • Group: minor bug --> none
     
  • Dale Anson

    Dale Anson - 2016-05-04

    I've added confirmation dialogs for Close Others, Close All, and Close All (Global). The dialogs are turned on by checking Utilities - Global Options - General - "Close All" asks for confirmation.

     

Log in to post a comment.