#3742 VFSManager and WorkThreadpool wrong javadoc comments

closed-fixed
None
5
2012-09-01
2012-08-31
Jarek Czekalski
No

Sorry for the wrong comment on WorkThreadPool.addWorkRequest. It says
"will be executed in AWT thread. Otherwise, will be executed in work thread. It is never executed directly."

And that's not true, because if there are no work thread requests and current thread is EDT, it is executed directly.

Comments from 21578 need to be reanalyzed. But I rather wait for changes from Thomas, because I don't want to force him to rebase his patches.

Discussion

  • >As far as I understand this, it shouldn't matter if a call to
    >WorkThreadPool.addWorkRequest() with "inAWT = true" is processed
    >directly or queued for processing in the EventQueue, or should it?

    For designing the code flow it is crucial to know which code will be run first and which later. If you don't know whether the request will be processed directly or queued, you don't know what will be processed first: the code that follows or the code inside the request. If you don't know it, you have to be prepared for both options. So the api documentation should make no doubts about it. The doubts must be cleared.

    I decided that I have to make the changes now (r22108), because I need to submit a merge request to 5.0.x. Sorry for the inconvenience, Thomas.

     
    • status: open --> closed-fixed