Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#3733 suspicious BACK_TO_XML ruleset in maven, tld edit modes

minor bug
closed-fixed
Eric Le Lay
5
2012-08-26
2012-08-20
Eric Le Lay
No

I don't know much about edit modes, so I may be wrong, but the BACK_TO_XML ruleset is declared but not referenced anywhere in the maven and tld edit modes.
Contrary to this, in ant mode, it is referenced, to get back from SQL to XML rules.

So I think the BACK_TO_XML ruleset should be removed in maven & tld modes.
More generally, would it not be interesting to check for unused sections in our edit modes ?
I'm thinking of an XSL transformation to run on the edit modes directory...

Discussion

  • Dale Anson
    Dale Anson
    2012-08-20

    You're probably right -- I started with the Ant mode when I wrote those. There very well could be extras that should be removed.

     
  • Eric Le Lay
    Eric Le Lay
    2012-08-22

    OK, I'll work on it...

     
  • Eric Le Lay
    Eric Le Lay
    2012-08-22

    • assigned_to: nobody --> kerik-sf
     
  • Eric Le Lay
    Eric Le Lay
    2012-08-25

    Here's what I found, checking for either references to rulesets that do not exist or that are never referenced:
    mode bcel.xml undefined ref bcel::JAVADOC
    mode clips.xml undefined ref clips::LIST
    mode html.xml ruleset html::BACK_TO_HTML not referenced anywhere
    mode mail.xml ruleset mail::HEADER not referenced anywhere
    mode maven.xml ruleset maven::BACK_TO_XML not referenced anywhere
    mode objective-c.xml undefined ref objective-c::LEX
    mode perl.xml ruleset perl::REGEXP not referenced anywhere
    mode perl.xml ruleset perl::SUB_NAME not referenced anywhere
    mode powerdynamo.xml undefined ref powerdynamo::powerdynamo_LITERAL
    mode powerdynamo.xml undefined ref powerdynamo::powerdynamo_LITERAL
    mode powerdynamo.xml undefined ref powerdynamo::powerdynamo_LITERAL
    mode powerdynamo.xml undefined ref powerdynamo::powerdynamo_LITERAL
    mode powerdynamo.xml undefined ref powerdynamo::powerdynamo_LITERAL
    mode powerdynamo.xml undefined ref powerdynamo::powerdynamo_LITERAL
    mode powerdynamo.xml undefined ref powerdynamo::powerdynamo_LITERAL
    mode powerdynamo.xml undefined ref powerdynamo::powerdynamo_LITERAL
    mode ruby.xml ruleset rakefile::doubleQuoteSymbol not referenced anywhere
    mode ruby.xml ruleset ruby::doubleQuoteSymbol not referenced anywhere
    mode rview.xml undefined ref rview::JAVADOC
    mode tld.xml ruleset tld::BACK_TO_XML not referenced anywhere
    mode tthtml.xml undefined ref template-toolkit::VARIABLE
    mode url.xml undefined ref url::unwritten_AUTHORITY
    mode url.xml undefined ref url::unwritten_HOSTNAME
    mode vala.xml undefined ref vala::JAVADOC_PARAM
    mode vala.xml undefined ref vala::JAVADOC_PARAM
    mode vala.xml undefined ref vala::JAVADOC_PARAM
    mode yaml.xml ruleset yaml::AFTER_NAME not referenced anywhere
    mode yaml.xml undefined ref yaml::INVALID

    I'll try to correct them.

     
  • Eric Le Lay
    Eric Le Lay
    2012-08-26

    • status: open --> closed-fixed
     
  • Eric Le Lay
    Eric Le Lay
    2012-08-26

    fixed all I could find in r22058-r22071
    Added the XSLT as misc/mode_lint/mode_lint.xsl