#2810 4.3pre10(svn) breaks FTP "connect to secure FTP server" dlg

closed-fixed
None
7
2007-02-08
2007-02-07
Alan Ezust
No

The FTP plugin no longer shows me the textfields for username/pw/key location in the "connect to secure ftp server" dialog. All I can see is the "save password" checkbox.

Reverting back to 4.3pre9, it works again.

What broke?

Discussion

  • Logged In: YES
    user_id=631957
    Originator: NO

    VariableGridLayout.java is the culprit; the dialog uses that to layout its content and that file has been changed in rev 8845.

    The following diff shows what has changed:
    http://jedit.svn.sourceforge.net/viewvc/jedit/jEdit/trunk/org/gjt/sp/jedit/gui/VariableGridLayout.java?view=diff&r1=8266&r2=8845&diff_format=h

    Lines 433 and 463 are at fault - one has had a Math.min changed to Math.max and the other the opposite.

    Vampire0, you made this change as a part of adding the new LayoutManager. I don't want to undo your work if there is a good reason for this change. Can you comment please? The FTP dialog will not be the only casualty over this - but it seems to be the most visible.

     
    • milestone: --> Regressive (new to devel)
    • assigned_to: nobody --> vampire0
     
  • Alan Ezust
    Alan Ezust
    2007-02-08

    Logged In: YES
    user_id=935841
    Originator: YES

    thanks nicholas, I fixed it with your help.

    committed to 8924.

     
  • Alan Ezust
    Alan Ezust
    2007-02-08

    • status: open --> closed-fixed
     
  • Logged In: YES
    user_id=631957
    Originator: NO

    Alan, as long as we're happy this hasn't broken whatever vampire0 changed, then cool.

     
  • Björn Kautler
    Björn Kautler
    2007-03-08

    Logged In: YES
    user_id=918212
    Originator: NO

    Indeed both hat min changed to max. As I told Alan already this was because of a misconception of me and acutally was correct, so it was right to change it back.
    Just wanted to comment this here also. :-)